Attempt to shut down the connection gracefully in case of a TLS hands…

…hake exception
apache · Jul 8, 2024 · e009a92 · e009a92
1 parent 33debc6
commit e009a92
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 6 deletions.
diff --git a/...ore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java b/...ore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java
@@ -42,6 +42,7 @@
 import java.util.concurrent.ConcurrentLinkedQueue;
 import java.util.concurrent.atomic.AtomicInteger;
 
+import javax.net.ssl.SSLHandshakeException;
 import javax.net.ssl.SSLSession;
 
 import org.apache.hc.core5.concurrent.CancellableDependency;
@@ -698,6 +699,8 @@ public final void onException(final Exception cause) {
             final CloseMode closeMode;
             if (cause instanceof ConnectionClosedException) {
                 closeMode = CloseMode.GRACEFUL;
+            } else if (cause instanceof SSLHandshakeException) {
+                closeMode = CloseMode.GRACEFUL;
             } else if (cause instanceof IOException) {
                 closeMode = CloseMode.IMMEDIATE;
             } else {

diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/AbstractHttp1StreamDuplexer.java b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/AbstractHttp1StreamDuplexer.java
@@ -37,6 +37,7 @@
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.locks.ReentrantLock;
 
+import javax.net.ssl.SSLHandshakeException;
 import javax.net.ssl.SSLSession;
 
 import org.apache.hc.core5.http.ConnectionClosedException;
@@ -166,6 +167,8 @@ void shutdownSession(final Exception cause) {
             final CloseMode closeMode;
             if (cause instanceof ConnectionClosedException) {
                 closeMode = CloseMode.GRACEFUL;
+            } else if (cause instanceof SSLHandshakeException) {
+                closeMode = CloseMode.GRACEFUL;
             } else if (cause instanceof IOException) {
                 closeMode = CloseMode.IMMEDIATE;
             } else {

diff --git a/httpcore5/src/main/java/org/apache/hc/core5/reactor/ssl/SSLIOSession.java b/httpcore5/src/main/java/org/apache/hc/core5/reactor/ssl/SSLIOSession.java
@@ -232,8 +232,12 @@ public void exception(final IOSession protocolSession, final Exception cause) {
                 }
                 final IOEventHandler handler = session.getHandler();
                 if (handshakeStateRef.get() != TLSHandShakeState.COMPLETE) {
-                    session.close(CloseMode.GRACEFUL);
-                    close(CloseMode.IMMEDIATE);
+                    if (cause instanceof SSLHandshakeException) {
+                        close(CloseMode.GRACEFUL);
+                    } else {
+                        session.close(CloseMode.GRACEFUL);
+                        close(CloseMode.IMMEDIATE);
+                    }
                 }
                 if (handler != null) {
                     handler.exception(protocolSession, cause);
@@ -467,13 +471,17 @@ private void updateEventMask() {
                 this.sslEngine.closeOutbound();
                 this.outboundClosedCount.incrementAndGet();
             }
-            if (this.status == Status.CLOSING && this.sslEngine.isOutboundDone()
+            final HandshakeStatus handshakeStatus = this.sslEngine.getHandshakeStatus();
+            if (this.status == Status.CLOSING
+                    && (handshakeStatus == HandshakeStatus.NOT_HANDSHAKING || handshakeStatus == HandshakeStatus.FINISHED)
+                    && !this.outEncrypted.hasData()
+                    && this.sslEngine.isOutboundDone()
                     && (this.endOfStream || this.sslEngine.isInboundDone())) {
                 this.status = Status.CLOSED;
             }
             // Abnormal session termination
             if (this.status.compareTo(Status.CLOSING) <= 0 && this.endOfStream
-                    && this.sslEngine.getHandshakeStatus() == HandshakeStatus.NEED_UNWRAP) {
+                    && handshakeStatus == HandshakeStatus.NEED_UNWRAP) {
                 this.status = Status.CLOSED;
             }
             if (this.status == Status.CLOSED) {
@@ -484,7 +492,7 @@ private void updateEventMask() {
                 return;
             }
             // Is there a task pending?
-            if (this.sslEngine.getHandshakeStatus() == HandshakeStatus.NEED_TASK) {
+            if (handshakeStatus == HandshakeStatus.NEED_TASK) {
                 doRunTask();
             }
             // Need to toggle the event mask for this channel?
@@ -527,7 +535,7 @@ private void updateEventMask() {
     private int sendEncryptedData() throws IOException {
         this.session.getLock().lock();
         try {
-            if (!this.outEncrypted.hasData()) {
+            if (this.status == Status.ACTIVE && !this.outEncrypted.hasData()) {
                 // If the buffer isn't acquired or is empty, call write() with an empty buffer.
                 // This will ensure that tests performed by write() still take place without
                 // having to acquire and release an empty buffer (e.g. connection closed,
@@ -719,6 +727,8 @@ public void close(final CloseMode closeMode) {
                     // in the JSSE provider. For instance
                     // com.android.org.conscrypt.NativeCrypto#SSL_get_shutdown can
                     // throw NPE at this point
+                    doHandshake(this);
+                    sendEncryptedData();
                     updateEventMask();
                 } catch (final CancelledKeyException ex) {
                     this.session.close(CloseMode.GRACEFUL);