Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use either US-ASCII or UTF-8 encoding for text where approriate #375

Merged
merged 1 commit into from Feb 14, 2023

Conversation

michael-o
Copy link
Member

Previously, text-based content was many times encoded with ISO-8859-1. This has gradually fallen out of use in the past 10 to 15 years. Use US-ASCII where a 7-bit encoding scheme is required for everything related to text encoding use UTF-8.

This is just a draft to move to UTF-8. May contain incorrect changes. Intended for 5.3+ only.

@michael-o
Copy link
Member Author

As discussed in HTTPCLIENT-2244.

Copy link
Member

@ok2c ok2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-o Everything looks correct to me.

@michael-o michael-o marked this pull request as ready for review December 28, 2022 21:19
Previously, text-based content was many times encoded with ISO-8859-1.
This has gradually fallen out of use in the past 10 to 15 years. Use
US-ASCII where a 7-bit encoding scheme is required for everything
related to text encoding use UTF-8.
@michael-o michael-o changed the base branch from master to 5.3.x February 14, 2023 21:26
@asfgit asfgit merged commit b227289 into 5.3.x Feb 14, 2023
@michael-o michael-o deleted the real-world-encoding branch February 14, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants