Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak FLUSH handling in mod_deflate input filter #280

Closed
wants to merge 1 commit into from
Closed

Tweak FLUSH handling in mod_deflate input filter #280

wants to merge 1 commit into from

Conversation

notroj
Copy link
Collaborator

@notroj notroj commented Dec 3, 2021 

* modules/filters/mod_deflate.c (deflate_in_filter): Handle FLUSH in
  the input brigade even if done inflating (ctx->done is true), but
  don't try to flush the inflate stream in that case.  (Caught by
  Coverity)

rpluem
rpluem reviewed Dec 3, 2021
View reviewed changes
modules/filters/mod_deflate.c Outdated
@@ -1298,6 +1298,7 @@ static apr_status_t deflate_in_filter(ap_filter_t *f,
{
const char *data;
apr_size_t len;
apr_bucket *tmp_b;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we move this to line 1354? The block starting there seems to be the only one that needs it.

modules/filters/mod_deflate.c Outdated Show resolved Hide resolved
@notroj
* modules/filters/mod_deflate.c (deflate_in_filter): Handle FLUSH in
99c468e 
  the input brigade even if done inflating (ctx->done is true), but
  don't try to flush the inflate stream in that case.  (Caught by
  Coverity)
@asfgit asfgit closed this in 6aef687 Dec 3, 2021
@notroj notroj deleted the deflate-tweak branch December 3, 2021 15:06
notroj added a commit to notroj/httpd that referenced this pull request Mar 18, 2024
@notroj
* modules/filters/mod_deflate.c (deflate_in_filter): Handle FLUSH in
8836713 
  the input brigade even if done inflating (ctx->done is true), but
  don't try to flush the inflate stream in that case.  (Caught by
  Coverity)

Github: closes apache#280

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1895552 13f79535-47bb-0310-9956-ffa450edef68
(cherry picked from commit 6aef687)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpluem rpluem rpluem left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@notroj @rpluem