mod_xml2enc: remove dependency on xmlstring header #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess both casts are ugly, but should we be including libxml/parser.h here? |
|
libxml/encoding.h is included in mod_xml2enc.c. actually, libxml/encoding.h has no dependencies on libxml/xmlstring.h. instead of adding more headers, eliminate reference to xmlChar defined in libxml/xmlstring.h to reduce unnecessary dependencies. |
|
Thanks, I see now, the type has never been in the signature of xmlDetectCharEncoding |
nono303
pushed a commit
to nono303/win-build-scripts
that referenced
this pull request
Dec 18, 2023
asfgit
pushed a commit
that referenced
this pull request
Jan 3, 2024
mod_xml2enc: remove dependency on xmlstring header Submitted by: ttachi <tachihara hotmail.com> Github: closes #393 Reviewed by: covener, minfrin, jorton git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1915066 13f79535-47bb-0310-9956-ffa450edef68
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Feb 6, 2024
See the pull apache/httpd#393. Signed-off-by: INODE64 <web@inode64.com> Closes: #35118 Signed-off-by: Sam James <sam@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include of libxml/xmlstring.h was removed from libxml/encoding.h in libxml2 v2.12.0
GNOME/libxml2@7909ff0