Fix proxy determine address #454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
output when dumping multiple resolved addresses. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1918228 13f79535-47bb-0310-9956-ffa450edef68
…red addressTTL. BZ 69126 * modules/proxy/proxy_util.c(ap_proxy_determine_address): Fix shared expiry compare-and-swap loop. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1918410 13f79535-47bb-0310-9956-ffa450edef68
…'t change. * modules/proxy/proxy_util.c(address_cleanup): Rename to conn_cleanup() since it also closes the socket, and run socket_cleanup() first to avoid dangling conn->sock->remote_addr. * modules/proxy/proxy_util.c(ap_proxy_determine_address): Compare the new address with the old one and keep the socket alive if it did not change. Follow up to r1918410. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1918412 13f79535-47bb-0310-9956-ffa450edef68
…t] is alive. ap_proxy_connect_backend() will use the first conn->addr[->next] that works, so the current address alive can be any of them. * modules/proxy/proxy_util.c(ap_proxy_determine_address): Loop for all conn->addr[->next] to determine if addr_alive. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1918429 13f79535-47bb-0310-9956-ffa450edef68
… only. apr_socket_connect() on unixes does copy the passed in *addr, so limit the liefetime workaround to Windows and OS/2 only (which don't). * modules/proxy/proxy_util.c(ap_proxy_determine_address): #ifdef the relevant code for WIN32/OS2 only, and improve comment. git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1918438 13f79535-47bb-0310-9956-ffa450edef68
ylavic
force-pushed
the
fix_proxy_determine_address
branch
from
96b3122
to
e89e206
Compare
…he address cleanup. * modules/proxy/proxy_util.c(ap_proxy_determine_address): Move conn_cleanup() after apr_pool_cleanup_run(). git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1918442 13f79535-47bb-0310-9956-ffa450edef68
asfgit
pushed a commit
that referenced
this pull request
Jun 24, 2024
*) mod_proxy: Fix DNS requests and connections closed before the
configured addressTTL. BZ 69126. [Yann Ylavic]
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1918543 13f79535-47bb-0310-9956-ffa450edef68
|
Merged in c66fe1a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.