Skip to content

Commit

Permalink
added review comments for style and renaming
Browse files Browse the repository at this point in the history
  • Loading branch information
harsh1231 committed Dec 16, 2021
1 parent 1be1900 commit 02473f5
Showing 1 changed file with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ case class HoodieFileIndex(
private lazy val _partitionSchemaFromProperties: StructType = {
val tableConfig = metaClient.getTableConfig
val partitionColumns = tableConfig.getPartitionFields
val nameFieldMap = convertStructToMap(Right(schema))
val nameFieldMap = generateNameFieldMap(Right(schema))

if (partitionColumns.isPresent) {
val partitionFields = partitionColumns.get().map(column =>
Expand All @@ -130,12 +130,12 @@ case class HoodieFileIndex(
* @param structField
* @return map of ( columns names -> StructField )
*/
private def convertStructToMap(structField : Either[StructField,StructType]) : Map[String,StructField] = {
private def generateNameFieldMap(structField : Either[StructField, StructType]) : Map[String, StructField] = {
structField match {
case Right(field) => field.fields.map(f => convertStructToMap(Left(f))).flatten.toMap
case Right(field) => field.fields.map(f => generateNameFieldMap(Left(f))).flatten.toMap
case Left(field) => field.dataType match {
case struct: StructType => convertStructToMap(Right(struct)).map {
case (key :String , sf:StructField) => (field.name + "." + key , sf )
case struct: StructType => generateNameFieldMap(Right(struct)).map {
case (key: String, sf: StructField) => (field.name + "." + key, sf)
}
case _ => Map(field.name -> field)
}
Expand Down

0 comments on commit 02473f5

Please sign in to comment.