CodeStyle formatting to conform to basic Checkstyle rules.

The code-style rules follow google style with some changes:

1. Increase line length from 100 to 120
2. Disable JavaDoc related checkstyles as this needs more manual work.

Both source and test code are checked for code-style

docs/dev_setup.md

@@ -7,8 +7,7 @@ permalink: dev_setup.html
 
 ### Code Style
 
- We have embraced the [Google Java code style](https://google.github.io/styleguide/javaguide.html). Please setup your IDE accordingly with style files from [here](https://github.com/google/styleguide/blob/gh-pages/intellij-java-google-style.xml)
- Also recommend setting up the [Save Action Plugin](https://plugins.jetbrains.com/plugin/7642-save-actions) to auto format & organize imports on save.
-
-
-
+ We have embraced the code style largely based on [google format](https://google.github.io/styleguide/javaguide.html).
+ Please setup your IDE with style files from [here](../style/)
+ We also recommend setting up the [Save Action Plugin](https://plugins.jetbrains.com/plugin/7642-save-actions) to auto format & organize imports on save.
+ The Maven Compilation life-cycle will fail if there are checkstyle violations.

hoodie-cli/src/main/java/com/uber/hoodie/cli/HoodiePrompt.java

@@ -35,10 +35,10 @@ public String getPrompt() {
         case DATASET:
           return "hoodie:" + tableName + "->";
         case SYNC:
-          return "hoodie:" + tableName + " <==> "
-              + HoodieCLI.syncTableMetadata.getTableConfig().getTableName() + "->";
+          return "hoodie:" + tableName + " <==> " + HoodieCLI.syncTableMetadata.getTableConfig().getTableName() + "->";
+        default:
+          return "hoodie:" + tableName + "->";
       }
-      return "hoodie:" + tableName + "->";
     }
     return "hoodie->";
   }

hoodie-cli/src/main/java/com/uber/hoodie/cli/HoodieSplashScreen.java

@@ -24,22 +24,18 @@
 
 @Component
 @Order(Ordered.HIGHEST_PRECEDENCE)
-public class HoodieSplashScreen
-    extends DefaultBannerProvider {
-
-  private static String screen =
-      "============================================" + OsUtils.LINE_SEPARATOR +
-          "*                                          *" + OsUtils.LINE_SEPARATOR +
-          "*     _    _                 _ _           *" + OsUtils.LINE_SEPARATOR +
-          "*    | |  | |               | (_)          *" + OsUtils.LINE_SEPARATOR +
-          "*    | |__| | ___   ___   __| |_  ___      *" + OsUtils.LINE_SEPARATOR +
-          "*    |  __  |/ _ \\ / _ \\ / _` | |/ _ \\     *" +
-          OsUtils.LINE_SEPARATOR +
-          "*    | |  | | (_) | (_) | (_| | |  __/     *" + OsUtils.LINE_SEPARATOR +
-          "*    |_|  |_|\\___/ \\___/ \\__,_|_|\\___|     *" +
-          OsUtils.LINE_SEPARATOR +
-          "*                                          *" + OsUtils.LINE_SEPARATOR +
-          "============================================" + OsUtils.LINE_SEPARATOR;
+public class HoodieSplashScreen extends DefaultBannerProvider {
+
+  private static String screen = "============================================" + OsUtils.LINE_SEPARATOR
+      + "*                                          *" + OsUtils.LINE_SEPARATOR
+      + "*     _    _                 _ _           *" + OsUtils.LINE_SEPARATOR
+      + "*    | |  | |               | (_)          *" + OsUtils.LINE_SEPARATOR
+      + "*    | |__| | ___   ___   __| |_  ___      *" + OsUtils.LINE_SEPARATOR
+      + "*    |  __  |/ _ \\ / _ \\ / _` | |/ _ \\     *" + OsUtils.LINE_SEPARATOR
+      + "*    | |  | | (_) | (_) | (_| | |  __/     *" + OsUtils.LINE_SEPARATOR
+      + "*    |_|  |_|\\___/ \\___/ \\__,_|_|\\___|     *" + OsUtils.LINE_SEPARATOR
+      + "*                                          *" + OsUtils.LINE_SEPARATOR
+      + "============================================" + OsUtils.LINE_SEPARATOR;
 
   public String getBanner() {
     return screen;

hoodie-cli/src/main/java/com/uber/hoodie/cli/Main.java

@@ -22,8 +22,7 @@
 public class Main {
 
   /**
-   * Main class that delegates to Spring Shell's Bootstrap class in order to simplify debugging
-   * inside an IDE
+   * Main class that delegates to Spring Shell's Bootstrap class in order to simplify debugging inside an IDE
    */
   public static void main(String[] args) throws IOException {
     Bootstrap.main(args);

hoodie-cli/src/main/java/com/uber/hoodie/cli/commands/ArchivedCommitsCommand.java

@@ -47,22 +47,19 @@ public boolean isShowArchivedCommitAvailable() {
   }
 
   @CliCommand(value = "show archived commits", help = "Read commits from archived files and show details")
-  public String showCommits(
-      @CliOption(key = {
-          "limit"}, mandatory = false, help = "Limit commits", unspecifiedDefaultValue = "10")
-      final Integer limit) throws IOException {
+  public String showCommits(@CliOption(key = {
+      "limit"}, mandatory = false, help = "Limit commits", unspecifiedDefaultValue = "10") final Integer limit)
+      throws IOException {
 
-    System.out
-        .println("===============> Showing only " + limit + " archived commits <===============");
+    System.out.println("===============> Showing only " + limit + " archived commits <===============");
     String basePath = HoodieCLI.tableMetadata.getBasePath();
     FileStatus[] fsStatuses = FSUtils.getFs(basePath, HoodieCLI.conf)
         .globStatus(new Path(basePath + "/.hoodie/.commits_.archive*"));
     List<String[]> allCommits = new ArrayList<>();
     int commits = 0;
     for (FileStatus fs : fsStatuses) {
       //read the archived file
-      HoodieLogFormat.Reader reader = HoodieLogFormat
-          .newReader(FSUtils.getFs(basePath, HoodieCLI.conf),
+      HoodieLogFormat.Reader reader = HoodieLogFormat.newReader(FSUtils.getFs(basePath, HoodieCLI.conf),
           new HoodieLogFile(fs.getPath()), HoodieArchivedMetaEntry.getClassSchema());
 
       List<IndexedRecord> readRecords = new ArrayList<>();
@@ -71,20 +68,19 @@ public String showCommits(
         HoodieAvroDataBlock blk = (HoodieAvroDataBlock) reader.next();
         List<IndexedRecord> records = blk.getRecords();
         readRecords.addAll(records);
-        if(commits == limit) {
+        if (commits == limit) {
           break;
         }
         commits++;
       }
-      List<String[]> readCommits = readRecords.stream().map(r -> (GenericRecord) r)
-          .map(r -> readCommit(r)).collect(Collectors.toList());
+      List<String[]> readCommits = readRecords.stream().map(r -> (GenericRecord) r).map(r -> readCommit(r))
+          .collect(Collectors.toList());
       allCommits.addAll(readCommits);
-      if(commits == limit) {
+      if (commits == limit) {
         break;
       }
     }
-    return HoodiePrintHelper.print(
-        new String[]{"CommitTime", "CommitType", "CommitDetails"},
+    return HoodiePrintHelper.print(new String[] {"CommitTime", "CommitType", "CommitDetails"},
         allCommits.toArray(new String[allCommits.size()][]));
   }
 
@@ -122,6 +118,8 @@ private String[] readCommit(GenericRecord record) {
           commitDetails.add(record.get("hoodieSavePointMetadata").toString());
           break;
         }
+        default:
+          return commitDetails.toArray(new String[commitDetails.size()]);
       }
     } catch (Exception e) {
       e.printStackTrace();

hoodie-cli/src/main/java/com/uber/hoodie/cli/commands/CleansCommand.java

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 package com.uber.hoodie.cli.commands;
 
 import com.uber.hoodie.avro.model.HoodieCleanMetadata;
@@ -63,51 +64,46 @@ public String showCleans() throws IOException {
     Collections.reverse(cleans);
     for (int i = 0; i < cleans.size(); i++) {
       HoodieInstant clean = cleans.get(i);
-      HoodieCleanMetadata cleanMetadata =
-          AvroUtils.deserializeHoodieCleanMetadata(timeline.getInstantDetails(clean).get());
-      rows[i] = new String[]{clean.getTimestamp(), cleanMetadata.getEarliestCommitToRetain(),
-          String.valueOf(cleanMetadata.getTotalFilesDeleted()),
-          String.valueOf(cleanMetadata.getTimeTakenInMillis())};
+      HoodieCleanMetadata cleanMetadata = AvroUtils
+          .deserializeHoodieCleanMetadata(timeline.getInstantDetails(clean).get());
+      rows[i] = new String[] {clean.getTimestamp(), cleanMetadata.getEarliestCommitToRetain(),
+          String.valueOf(cleanMetadata.getTotalFilesDeleted()), String.valueOf(cleanMetadata.getTimeTakenInMillis())};
     }
-    return HoodiePrintHelper.print(
-        new String[]{"CleanTime", "EarliestCommandRetained", "Total Files Deleted",
-            "Total Time Taken"}, rows);
+    return HoodiePrintHelper
+        .print(new String[] {"CleanTime", "EarliestCommandRetained", "Total Files Deleted", "Total Time Taken"},
+            rows);
   }
 
   @CliCommand(value = "cleans refresh", help = "Refresh the commits")
   public String refreshCleans() throws IOException {
-    HoodieTableMetaClient metadata =
-        new HoodieTableMetaClient(HoodieCLI.conf, HoodieCLI.tableMetadata.getBasePath());
+    HoodieTableMetaClient metadata = new HoodieTableMetaClient(HoodieCLI.conf, HoodieCLI.tableMetadata.getBasePath());
     HoodieCLI.setTableMetadata(metadata);
     return "Metadata for table " + metadata.getTableConfig().getTableName() + " refreshed.";
   }
 
   @CliCommand(value = "clean showpartitions", help = "Show partition level details of a clean")
-  public String showCleanPartitions(
-      @CliOption(key = {"clean"}, help = "clean to show")
-      final String commitTime) throws Exception {
+  public String showCleanPartitions(@CliOption(key = {"clean"}, help = "clean to show") final String commitTime)
+      throws Exception {
     HoodieActiveTimeline activeTimeline = HoodieCLI.tableMetadata.getActiveTimeline();
     HoodieTimeline timeline = activeTimeline.getCleanerTimeline().filterCompletedInstants();
-    HoodieInstant cleanInstant =
-        new HoodieInstant(false, HoodieTimeline.CLEAN_ACTION, commitTime);
+    HoodieInstant cleanInstant = new HoodieInstant(false, HoodieTimeline.CLEAN_ACTION, commitTime);
 
     if (!timeline.containsInstant(cleanInstant)) {
       return "Clean " + commitTime + " not found in metadata " + timeline;
     }
-    HoodieCleanMetadata cleanMetadata =
-        AvroUtils.deserializeHoodieCleanMetadata(timeline.getInstantDetails(cleanInstant).get());
+    HoodieCleanMetadata cleanMetadata = AvroUtils.deserializeHoodieCleanMetadata(
+        timeline.getInstantDetails(cleanInstant).get());
     List<String[]> rows = new ArrayList<>();
-    for (Map.Entry<String, HoodieCleanPartitionMetadata> entry : cleanMetadata
-        .getPartitionMetadata().entrySet()) {
+    for (Map.Entry<String, HoodieCleanPartitionMetadata> entry : cleanMetadata.getPartitionMetadata().entrySet()) {
       String path = entry.getKey();
       HoodieCleanPartitionMetadata stats = entry.getValue();
       String policy = stats.getPolicy();
       String totalSuccessDeletedFiles = String.valueOf(stats.getSuccessDeleteFiles().size());
       String totalFailedDeletedFiles = String.valueOf(stats.getFailedDeleteFiles().size());
-      rows.add(new String[]{path, policy, totalSuccessDeletedFiles, totalFailedDeletedFiles});
+      rows.add(new String[] {path, policy, totalSuccessDeletedFiles, totalFailedDeletedFiles});
     }
     return HoodiePrintHelper.print(
-        new String[]{"Partition Path", "Cleaning policy", "Total Files Successfully Deleted",
+        new String[] {"Partition Path", "Cleaning policy", "Total Files Successfully Deleted",
             "Total Failed Deletions"}, rows.toArray(new String[rows.size()][]));
   }
 }