Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc][chinese] Translate the release page into chinese documentation #1033

Merged
merged 2 commits into from
Nov 21, 2019
Merged

[doc][chinese] Translate the release page into chinese documentation #1033

merged 2 commits into from
Nov 21, 2019

Conversation

lamberken
Copy link
Member

What is the purpose of the pull request

Translate the release page into chinese documentation

Brief change log

  • Translate the release page into chinese documentation
  • Modify mydoc_sidebar_cn
  • Add strings_cn
  • Fix typo in quickstart

Verify this pull request

This pull request is a doc work without any test coverage.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@lamberken
Copy link
Member Author

hi, @leesf, help to review, thanks.

Comment on lines -6 to -7
- title: 新闻
url: /news
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why get dropped?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the english doc has removed this.
image

docs/releases.cn.md Outdated Show resolved Hide resolved
docs/releases.cn.md Outdated Show resolved Hide resolved
docs/releases.cn.md Outdated Show resolved Hide resolved
docs/releases.cn.md Outdated Show resolved Hide resolved
@leesf
Copy link
Contributor

leesf commented Nov 20, 2019

Thanks for opening the PR @lamber-ken ! Looks good overall, only left some minor comments. Also, would you please paste the page snapshot after modification?

@lamberken
Copy link
Member Author

@leesf , thanks for review and suggestion, here is the snapshot
image

Copy link
Contributor

@leesf leesf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging...

@leesf leesf merged commit 55b990d into apache:asf-site Nov 21, 2019
@lamberken lamberken deleted the asf-site-release branch May 2, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants