[HUDI-7391] HoodieMetadataMetrics should use Metrics instance for metrics registry #10635
+643
−336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @prashantwason : can you review this patch please |
nsivabalan
reviewed
Feb 10, 2024
hudi-common/src/main/java/org/apache/hudi/metrics/MetricsReporterFactory.java
Show resolved
Hide resolved
nsivabalan
requested changes
Apr 7, 2024
...ient/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataWriteUtils.java
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java
Show resolved
Hide resolved
| @@ -166,6 +169,17 @@ public void registerGauge(String metricName, final long value) { | |||
| } | |||
| } | |||
|
|
|||
| public HoodieGauge<Long> registerGauge(String metricName) { | |||
| try { | |||
There was a problem hiding this comment.
why can't we call the other method here.
registerGauge(String metricName, 0L);
There was a problem hiding this comment.
lets address this minor comment and we are good to land
nsivabalan
approved these changes
Apr 10, 2024
yihua
pushed a commit
that referenced
this pull request
May 14, 2024
…rics registry (#10635) Currently HoodieMetadataMetrics stores metrics in memory and these metrics are not pushed by the metric reporters. The metric reporters are configured within Metrics instance. List of changes in the PR: Metrics related classes have been moved from hudi-client-common to hudi-common. HoodieMetadataMetrics now uses Metrics class so that all the reporters can be supported with it. Some gaps in configs which are added in HoodieMetadataWriteUtils Some metrics related apis and functionality has been moved to HoodieMetricsConfig. The HoodieWriteConfig APIs now delegate to HoodieMetricsConfig for the functionality.
yihua
pushed a commit
that referenced
this pull request
May 14, 2024
…rics registry (#10635) Currently HoodieMetadataMetrics stores metrics in memory and these metrics are not pushed by the metric reporters. The metric reporters are configured within Metrics instance. List of changes in the PR: Metrics related classes have been moved from hudi-client-common to hudi-common. HoodieMetadataMetrics now uses Metrics class so that all the reporters can be supported with it. Some gaps in configs which are added in HoodieMetadataWriteUtils Some metrics related apis and functionality has been moved to HoodieMetricsConfig. The HoodieWriteConfig APIs now delegate to HoodieMetricsConfig for the functionality.
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
…rics registry (#10635) Currently HoodieMetadataMetrics stores metrics in memory and these metrics are not pushed by the metric reporters. The metric reporters are configured within Metrics instance. List of changes in the PR: Metrics related classes have been moved from hudi-client-common to hudi-common. HoodieMetadataMetrics now uses Metrics class so that all the reporters can be supported with it. Some gaps in configs which are added in HoodieMetadataWriteUtils Some metrics related apis and functionality has been moved to HoodieMetricsConfig. The HoodieWriteConfig APIs now delegate to HoodieMetricsConfig for the functionality.
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
…rics registry (#10635) Currently HoodieMetadataMetrics stores metrics in memory and these metrics are not pushed by the metric reporters. The metric reporters are configured within Metrics instance. List of changes in the PR: Metrics related classes have been moved from hudi-client-common to hudi-common. HoodieMetadataMetrics now uses Metrics class so that all the reporters can be supported with it. Some gaps in configs which are added in HoodieMetadataWriteUtils Some metrics related apis and functionality has been moved to HoodieMetricsConfig. The HoodieWriteConfig APIs now delegate to HoodieMetricsConfig for the functionality.
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
…rics registry (#10635) Currently HoodieMetadataMetrics stores metrics in memory and these metrics are not pushed by the metric reporters. The metric reporters are configured within Metrics instance. List of changes in the PR: Metrics related classes have been moved from hudi-client-common to hudi-common. HoodieMetadataMetrics now uses Metrics class so that all the reporters can be supported with it. Some gaps in configs which are added in HoodieMetadataWriteUtils Some metrics related apis and functionality has been moved to HoodieMetricsConfig. The HoodieWriteConfig APIs now delegate to HoodieMetricsConfig for the functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Currently HoodieMetadataMetrics stores metrics in memory and these metrics are not pushed by the metric reporters. The metric reporters are configured within Metrics instance. List of changes in the PR:
Impact
There are constructors and APIs which were using
HoodieWriteConfigearlier. Now they are usingHoodieMetricsConfig.HoodieMetricsConfigcan be obtained by callinggetMetricsConfig()from theHoodieWriteConfigobject.Risk level (write none, low medium or high below)
low
Documentation Update
There are constructors and APIs which were using
HoodieWriteConfigearlier. Now they are usingHoodieMetricsConfig.HoodieMetricsConfigcan be obtained by callinggetMetricsConfig()from theHoodieWriteConfigobject.Contributor's checklist