[HUDI-6947] Refactored HoodieSchemaUtils.deduceWriterSchema with many flags #10810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geserdugarov
force-pushed
the
HUDI-6947-refactored-hoodieschemautils-flags
branch
from
d0f3399
to
137b32a
Compare
|
Hmm, good code quality is what we always in persuit with. |
geserdugarov
force-pushed
the
HUDI-6947-refactored-hoodieschemautils-flags
branch
from
137b32a
to
6e22785
Compare
|
Please, look at diffs in a split regime. The main refactoring is in the |
|
@geserdugarov thanks for the contribution! I will review this today |
yihua
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Current implementation of
HoodieSchemaUtils.deduceWriterSchemais really complicated with many flags used in one place.To figure out how this method is working, we need to draw directed acyclic graph. Here the current implementation:
Yellow is used for marking of flags, and purple is used for marking of returned schemas or exceptions.
We couldn't remove any of the used flags without changing processing logic. The only possibility is to refactor
deduceWriterSchema()for simplification, and preparing for future removing of deprecatedhoodie.datasource.write.reconcile.schema.This MR proposes to consider the following changed processing schema:
Impact
Refactored
HoodieSchemaUtils.deduceWriterSchema.Risk level (write none, low medium or high below)
Low.
Documentation Update
No need.
Contributor's checklist