[HUDI-7565] Create spark file readers to read a single file instead of an entire partition #10954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
yihua
reviewed
Apr 2, 2024
...in/scala/org/apache/spark/sql/execution/datasources/parquet/Spark24HoodieParquetReader.scala
Outdated
Show resolved
Hide resolved
yihua
reviewed
Apr 2, 2024
...in/scala/org/apache/spark/sql/execution/datasources/parquet/Spark24HoodieParquetReader.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/apache/spark/sql/execution/datasources/parquet/Spark24HoodieParquetReader.scala
Outdated
Show resolved
Hide resolved
added 15 commits
April 3, 2024 17:24
added 2 commits
April 4, 2024 14:14
yihua
reviewed
Apr 11, 2024
...in/scala/org/apache/spark/sql/execution/datasources/parquet/Spark31HoodieParquetReader.scala
Outdated
Show resolved
Hide resolved
yihua
reviewed
Apr 11, 2024
| * @param sharedConf the hadoop conf | ||
| * @return iterator of rows read from the file output type says [[InternalRow]] but could be [[ColumnarBatch]] | ||
| */ | ||
| def read(file: PartitionedFile, |
There was a problem hiding this comment.
I was thinking that SparkHoodieParquetReader.read can be unit-tested by passing in parameters and validating the output iterator of the InternalRows. For now, the functional test serves similar purpose.
...main/scala/org/apache/spark/sql/execution/datasources/parquet/SparkHoodieParquetReader.scala
Outdated
Show resolved
Hide resolved
...main/scala/org/apache/spark/sql/execution/datasources/parquet/SparkHoodieParquetReader.scala
Outdated
Show resolved
Hide resolved
...main/scala/org/apache/spark/sql/execution/datasources/parquet/SparkHoodieParquetReader.scala
Outdated
Show resolved
Hide resolved
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/hudi/SparkAdapter.scala
Outdated
Show resolved
Hide resolved
...source/hudi-spark/src/test/java/org/apache/hudi/functional/TestSparkHoodieParquetReader.java
Outdated
Show resolved
Hide resolved
...in/scala/org/apache/spark/sql/execution/datasources/parquet/Spark24HoodieParquetReader.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/apache/spark/sql/execution/datasources/parquet/Spark30HoodieParquetReader.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/apache/spark/sql/execution/datasources/parquet/Spark31HoodieParquetReader.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/apache/spark/sql/execution/datasources/parquet/Spark31HoodieParquetReader.scala
Outdated
Show resolved
Hide resolved
yihua
reviewed
Apr 11, 2024
...in/scala/org/apache/spark/sql/execution/datasources/parquet/Spark32HoodieParquetReader.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/apache/spark/sql/execution/datasources/parquet/Spark33HoodieParquetReader.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/apache/spark/sql/execution/datasources/parquet/Spark34HoodieParquetReader.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/apache/spark/sql/execution/datasources/parquet/Spark34HoodieParquetReader.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/apache/spark/sql/execution/datasources/parquet/Spark35HoodieParquetReader.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Subtask of https://issues.apache.org/jira/browse/HUDI-7045
Extracts from #10278
Spark parquet readers are created per partition. We want to create a reader for each file. This pr ports over the spark readers for each version and removes the partition iterator.
To verify the ported code, I have listed the ported spark version in the javadoc for readParquetFile
You can use the following link and switch between tags to see the code for that spark version
https://github.com/apache/spark/blob/v2.4.8/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
Impact
Subtask for schema evolution support in new fg reader
Risk level (write none, low medium or high below)
low
Documentation Update
N/A
Contributor's checklist