[MINOR] Hudi CLI 'version' command output empty string #10973
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pt657407064
changed the title
danny0405
reviewed
Apr 8, 2024
| command: | ||
| version: | ||
| template: "classpath:version.txt" |
There was a problem hiding this comment.
Not very familiar with the Spring stuff, are we fixing the spring cmd?
There was a problem hiding this comment.
Yes, The version command in hudi CLI is not showing the current Hudi version.
There was a problem hiding this comment.
It was working until this file got removed since the hudi released 0.11.1. https://github.com/apache/hudi/blob/release-0.11.0/hudi-cli/src/main/java/org/apache/hudi/cli/HoodieSplashScreen.java#L60
|
Can you check the CI failures? |
codope
reviewed
Apr 9, 2024
| command: | ||
| version: | ||
| template: "classpath:version.txt" |
There was a problem hiding this comment.
CI issue has been fixed
|
@hudi-bot run azure |
pt657407064
force-pushed
the
cli_version_command
branch
from
e093cc8
to
fac97b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Hudi Cli version command output empty string. Adding property files to output the version number according with the hudi parent project version.
Impact
Will cause confusion for client without knowing the version number
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist