[HUDI-7606] Unpersist RDDs after table services, mainly compaction and clustering #11000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmahindra123
changed the title
nsivabalan
reviewed
Apr 12, 2024
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
Outdated
Show resolved
Hide resolved
rmahindra123
force-pushed
the
rm_fix_persist_rdds
branch
from
c6da103
to
6c81f31
Compare
nsivabalan
reviewed
Apr 12, 2024
| @@ -268,6 +268,7 @@ public boolean commitStats(String instantTime, HoodieData<WriteStatus> writeStat | |||
| commitCallback.call(new HoodieWriteCommitCallbackMessage( | |||
| instantTime, config.getTableName(), config.getBasePath(), stats, Option.of(commitActionType), extraMetadata)); | |||
| } | |||
| releaseResources(instantTime); | |||
There was a problem hiding this comment.
this code path covers all writers correct? spark ds writer, and deltastreamer?
There was a problem hiding this comment.
yes, since SparkRDDWriteClient implements the method and is used across Spark DS and deltastreamer, we should be good.
There was a problem hiding this comment.
I guess we are missing async compaction flows.
->
->
I don't think we are unpersisting rdds in this flow.
Likely same for async clustering too.
There was a problem hiding this comment.
Fixed it for all table services, for both inline and async flows.
There was a problem hiding this comment.
good catch btw
rmahindra123
changed the title
rmahindra123
force-pushed
the
rm_fix_persist_rdds
branch
from
6c81f31
to
7948894
Compare
rmahindra123
commented
Apr 14, 2024
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
Show resolved
Hide resolved
added 2 commits
April 14, 2024 01:29
nsivabalan
approved these changes
Apr 14, 2024
github-actions
bot
added
size:M
yihua
pushed a commit
that referenced
this pull request
May 14, 2024
…d clustering (#11000) --------- Co-authored-by: rmahindra123 <rmahindra@Rajeshs-MacBook-Pro.local>
yihua
pushed a commit
that referenced
this pull request
May 14, 2024
…d clustering (#11000) --------- Co-authored-by: rmahindra123 <rmahindra@Rajeshs-MacBook-Pro.local>
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
…d clustering (#11000) --------- Co-authored-by: rmahindra123 <rmahindra@Rajeshs-MacBook-Pro.local>
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
…d clustering (#11000) --------- Co-authored-by: rmahindra123 <rmahindra@Rajeshs-MacBook-Pro.local>
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
…d clustering (#11000) --------- Co-authored-by: rmahindra123 <rmahindra@Rajeshs-MacBook-Pro.local>
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
…d clustering (#11000) --------- Co-authored-by: rmahindra123 <rmahindra@Rajeshs-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Unpersist RDDs after table services. Currently, the releaseResources is only called for commit or deltacommits. Tests show that the RDDs persisted by compaction and clustering are not explicitly unpersisted.
Impact
Cleans up persisted rdds w/o leaving any residues.
Risk level (write none, low medium or high below)
Low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist