-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-7618] Add ability to ignore checkpoints in delta streamer #11018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
reviewed
Apr 15, 2024
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamer.java
Show resolved
Hide resolved
nsivabalan
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 minor nit
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamer.java
Outdated
Show resolved
Hide resolved
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamer.java
Outdated
Show resolved
Hide resolved
rmahindra123
suggested changes
Apr 16, 2024
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamer.java
Outdated
Show resolved
Hide resolved
rmahindra123
suggested changes
Apr 18, 2024
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamer.java
Outdated
Show resolved
Hide resolved
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamer.java
Outdated
Show resolved
Hide resolved
github-actions
bot
added
size:S
PR with lines of changes in (10, 100]
and removed
size:M
PR with lines of changes in (100, 300]
labels
Apr 18, 2024
rmahindra123
approved these changes
Apr 18, 2024
Hi, @nsivabalan the master compile got crush with this patch, can you take care of it? |
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
--ignore-checkpoint
in hoodieStreamer and logic to ignore checkpoint when param is setImpact
no major impact as this is a new feature
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist