Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-7623] Refactoring of RemoteHoodieTableFileSystemView and RequestHandler #11032

Conversation

wombatu-kun
Copy link
Contributor

@wombatu-kun wombatu-kun commented Apr 16, 2024

Change Logs

Found a lot of code duplicates and inconsistent naming in RemoteHoodieTableFileSystemView and RequestHandler classes.

  • removed code duplicates;
  • fixed logging;
  • fixed naming of constants (request urls);
  • moved some methods to right places;
  • removed extra newlines

Impact

none

Risk level (write none, low medium or high below)

none

Documentation Update

none

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:L PR with lines of changes in (300, 1000] label Apr 16, 2024
@wombatu-kun
Copy link
Contributor Author

@hudi-bot run azure

@wombatu-kun wombatu-kun force-pushed the MINOR_refactoring_RemoteHoodieTableFileSystemView branch from 4599676 to 4106226 Compare April 17, 2024 00:41
@wombatu-kun
Copy link
Contributor Author

@hudi-bot run azure

@wombatu-kun wombatu-kun force-pushed the MINOR_refactoring_RemoteHoodieTableFileSystemView branch 4 times, most recently from 51c17b0 to 940bcfc Compare April 20, 2024 13:46
@wombatu-kun wombatu-kun force-pushed the MINOR_refactoring_RemoteHoodieTableFileSystemView branch from 940bcfc to 61e61c2 Compare April 20, 2024 14:17
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@danny0405 danny0405 merged commit 08564b3 into apache:master Apr 21, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L PR with lines of changes in (300, 1000]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants