[HUDI-7624] Fixing index tagging duration

[nsivabalan]

Change Logs

Index lookup duration we emit as of now is buggy. We compute the duration before and after tag() call which is actually lazy. So, the actual lookup was not even triggered, but we compute the duration and emit the value. Within tag() calls, we do partitioners instantiation and few other minor things that runs in the driver and the index duration was referring to that.

We also confirmed from our production metrics.

duration from stream sync for one batch of ingest : 34 mins.
delta commit duration: 32 mins
index look up duration (buggy): 3.6 mins

So, fixing it in this patch. We are introducing a metric named "pre_write.lookup.duration" which will refer to duration of starting of write to the completion of building workload profile. Just when we are building the workload profile is when the entire dag is triggered and hence we can't split it up further.

Also removed the previous buggy metrics.

Testing:
Also tested manually. I injected 10 sec delay to bloom index check function (executor) and here are the duration from metrics.

hudi_trips_cow.commit.duration
value = 13886

hudi_trips_cow.pre_write.lookup.duration
value = 11411

hudi_trips_cow.index.lookup.duration
value = 987

Impact

Correct metric value for pre write duration.

Risk level (write none, low medium or high below)

low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

• The config description must be updated if new configs are added or the default value of the configs are changed
• Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
  ticket number here and follow the instruction to make
  changes to the website.

Contributor's checklist

• Read through contributor's guide
• Change Logs and Impact were stated clearly
• Adequate tests were added if applicable
• CI passed

[hudi-bot]

CI report:

• 2efa695 Azure: SUCCESS

Bot commands

@hudi-bot supports the following commands:

• @hudi-bot run azure re-run the last Azure build