[HUDI-7674] Fix Hudi CLI Command "metadata validate-files" to use file listing to validate #11100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense, there are some test failures we need to take care. |
…e listing to validate
balaji-varadarajan
force-pushed
the
HUDI-7674
branch
from
3cb15cd
to
efe2c45
Compare
yihua
reviewed
Apr 26, 2024
| @@ -285,13 +290,14 @@ public String validateFiles( | |||
| return "[ERROR] Metadata Table not enabled/initialized\n\n"; | |||
| } | |||
|
|
|||
| FileSystemBackedTableMetadata fsMetaReader = new FileSystemBackedTableMetadata(new HoodieLocalEngineContext(HoodieCLI.conf), | |||
| HoodieCLI.getTableMetaClient().getTableConfig(), new SerializableConfiguration(HoodieCLI.conf), | |||
| HoodieCLI.basePath); | |||
| HoodieMetadataConfig fsConfig = HoodieMetadataConfig.newBuilder().enable(false).build(); | |||
There was a problem hiding this comment.
nit: this can be removed since no longer used.
danny0405
approved these changes
Apr 27, 2024
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
…e listing to validate (#11100) Co-authored-by: Balaji Varadarajan <balaji@applied.co>
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
…e listing to validate (#11100) Co-authored-by: Balaji Varadarajan <balaji@applied.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
[HUDI-7674] Fix Hudi CLI Command "metadata validate-files" to use file listing to validate
Impact
Bug fix for a Hudi CLI command
Risk level (write none, low medium or high below)
Low
Documentation Update
No Config change
Contributor's checklist