[HUDI-7879] Optimize the redundant creation of HoodieTable in DataSourceInternalWriterHelper and the unnecessary parameters in createTable within BaseHoodieWriteClient. #11456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rceInternalWriterHelper and the unnecessary parameters in createTable within BaseHoodieWriteClient.
danny0405
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the initialization method of DataSourceInternalWriterHelper, it currently creates two identical HoodieTable instances. We should remove one of them. Also, when comparing the differences between the two HoodieTable instances, I noticed that the createTable method in BaseHoodieWriteClient includes a HadoopConfiguration parameter that isn't used by any implemented methods. I'm not sure why it was designed this way, but I think we can remove it.
Change Logs
None
Impact
None
Risk level (write none, low medium or high below)
low
Documentation Update
None
Contributor's checklist