[HUDI-7921] Making HoodieTable closeable #11494
Open
+753
−465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
changed the title
nsivabalan
changed the title
github-actions
bot
added
size:XL
nsivabalan
changed the title
nsivabalan
commented
Jun 27, 2024
| throw new HoodieLogCompactException(String.format("Cannot log compact since a compaction instant with greater " | ||
| + "timestamp exists. Instant details %s", compactionInstantWithGreaterTimestamp.get())); | ||
| } | ||
| try { |
There was a problem hiding this comment.
NTR: only change in this code block is the closing of HoodieTable.
nsivabalan
commented
Jun 27, 2024
| HoodieTable table = createTable(config, hadoopConf); | ||
| resolveWriteConflict(table, metadata, this.pendingInflightAndRequestedInstants); | ||
| HoodieTable<?, I, ?, T> table = createTable(config, hadoopConf); | ||
| try { |
There was a problem hiding this comment.
NTR: Even though HoodieTable implements AutoCloseable, I could not use try with resources construct. I wanna throw something specific if close of HoodieTable fails vs something fails within try block. hence had to take this route.
nsivabalan
commented
Jun 27, 2024
| if (shouldComplete && compactionMetadata.getCommitMetadata().isPresent()) { | ||
| completeCompaction(compactionMetadata.getCommitMetadata().get(), table, compactionInstantTime); | ||
| try { | ||
| HoodieTimeline pendingCompactionTimeline = table.getActiveTimeline().filterPendingCompactionTimeline(); |
There was a problem hiding this comment.
NTR: only change in this code block is the closing of HoodieTable.
nsivabalan
commented
Jun 27, 2024
| } else { | ||
| throw new HoodieClusteringException("Non clustering replace-commit inflight at timestamp " + clusteringInstant); | ||
| try { | ||
| HoodieTimeline pendingClusteringTimeline = table.getActiveTimeline().filterPendingReplaceTimeline(); |
There was a problem hiding this comment.
NTR: only change in this code block is the closing of HoodieTable.
nsivabalan
commented
Jun 27, 2024
| table.getMetaClient().reloadActiveTimeline(); | ||
| return true; | ||
| try { | ||
| HoodieTimeline pendingClusteringTimeline = table.getActiveTimeline().filterPendingReplaceTimeline(); |
There was a problem hiding this comment.
NTR: entire set of changes in this patch is about closing HoodieTables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Making HoodieTable Closeable. We have few resources initialized in HoodieTable file FileSysteViewManager and metadata. So introducing close in HoodieTable and closing out all resources instantiated.
Impact
Avoids memory leaks with WriteClients.
Risk level (write none, low medium or high below)
low.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist