[HUDI-980] Fixing dir path for metastore_db and derby.logs generated in hive tests #1688
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaradar
approved these changes
May 29, 2020
There was a problem hiding this comment.
Looks good @nsivabalan. Please go ahead and merge once the tests passes and cherry-pick
|
sure @bvaradar . thanks. |
Codecov Report
@@ Coverage Diff @@
## master #1688 +/- ##
=========================================
Coverage 18.19% 18.19%
Complexity 856 856
=========================================
Files 348 348
Lines 15344 15344
Branches 1523 1523
=========================================
Hits 2792 2792
Misses 12195 12195
Partials 357 357 Continue to review full report at Codecov.
|
nsivabalan
added a commit
that referenced
this pull request
May 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running TestHiveSyncTool, some remnants are found in source dir(hudi-hive-sync). Eg, metastore_db and derby.logs. This patch fixes the same. This indirectly causes compilation of hudi to fail. Once you run unit tests, if you try to compile, it may complain about license headers in these generated files.
Source: https://stackoverflow.com/questions/38377188/how-to-get-rid-of-derby-log-metastore-db-from-spark-shell
Verification:
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.