[HUDI-1023] Add validation error messages in delta sync #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- avoid overwrite index type - add more validation error message - make write config constants public
xushiyan
force-pushed
the
fix-deltrastreamer-index-config
branch
from
60ce80b
to
22533af
Compare
xushiyan
commented
Jun 7, 2020
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/DeltaSync.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1710 +/- ##
=========================================
Coverage 18.19% 18.20%
- Complexity 857 858 +1
=========================================
Files 348 348
Lines 15358 15357 -1
Branches 1525 1525
=========================================
+ Hits 2794 2795 +1
+ Misses 12206 12204 -2
Partials 358 358
Continue to review full report at Codecov.
|
| .withCompactionConfig(HoodieCompactionConfig.newBuilder().withPayloadClass(cfg.payloadClassName) | ||
| // Inline compaction is disabled for continuous mode. otherwise enabled for MOR | ||
| .withInlineCompaction(cfg.isInlineCompactionEnabled()).build()) | ||
| .forTable(cfg.targetTableName) | ||
| .withIndexConfig(HoodieIndexConfig.newBuilder().withIndexType(HoodieIndex.IndexType.BLOOM).build()) | ||
| .withAutoCommit(false).withProps(props); | ||
| .withAutoCommit(autoCommit).withProps(props); |
There was a problem hiding this comment.
but this will override this.. the withProps(). no?
There was a problem hiding this comment.
@vinothchandar you're right. it was my overlook. But i guess this line is redundant anyway as index is default to BLOOM, setting the index config may cause some confusion.
xushiyan
changed the title
vinothchandar
approved these changes
Jun 11, 2020
xushiyan
changed the title
|
@vinothchandar sure. ticket added. |
|
@vinothchandar Is this good to merge? :) |
|
yes sir.. on it.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change added tests and can be verified as follows:
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.