Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-1059] Adding test to WriteClient to validate update partition path with global bloom #1767

Conversation

nsivabalan
Copy link
Contributor

What is the purpose of the pull request

Adding a test to validate update partition path

Brief change log

Verify this pull request

this patch is just adding tests

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@nsivabalan nsivabalan force-pushed the AddUpdatePartitionPathGlobalBloomTestWriteClient branch from 6ef8fb1 to 21a6b5f Compare June 26, 2020 12:58
@leesf
Copy link
Contributor

leesf commented Jun 27, 2020

@xushiyan Could you please review this PR since you did the related work before.

@vinothchandar
Copy link
Member

@nsivabalan this is more than the 50 lines we agreed on for MINOR prefix. can you please file a JIRA and let me know if you think this quallifies for the MINOR prefix.

@xushiyan
Copy link
Member

@xushiyan Could you please review this PR since you did the related work before.

@leesf Yes I can look into this soon.

@nsivabalan nsivabalan changed the title [MINOR] Adding test to WriteClient to validate update partition path with global bloom [HUDI-1059] Adding test to WriteClient to validate update partition path with global bloom Jun 29, 2020
@nsivabalan
Copy link
Contributor Author

@xushiyan : can you review this when you get time.

@nsivabalan nsivabalan closed this Jul 4, 2020
@nsivabalan
Copy link
Contributor Author

Closing this in favor of #1793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants