[MINOR] Relocate jetty during shading/packaging for Databricks runtime #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @vinothchandar , apologies for directly involving you, but not sure how to get this item noticed. |
|
@clocklear No worries.. Queued it up! |
vinothchandar
changed the title
vinothchandar
approved these changes
Jul 3, 2020
|
Can we have the same for the hudi-utilities-bundle too, facing the same issue when running deltastreamer |
|
cc @pratyakshsharma do you want to take this up? please let me know |
|
https://issues.apache.org/jira/browse/HUDI-1199 filed for this |
Ack. |
|
#1990 raised for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
This pull-request relocates jetty during the packaging of
hudi-spark-bundle.I'm testing Hudi in Databricks and found there is a transitive dependency conflict around Jetty. (Databricks runtime 6.6)[https://docs.databricks.com/release-notes/runtime/6.6.html] provides Jetty 9.3; Hudi has a dependency on Jetty 9.4 (specifically,
SessionHandler.setHttpOnly()doesn't exist in 9.3). (Databricks runtime 7.0)[https://docs.databricks.com/release-notes/runtime/7.0.html) includes Jetty 9.4, but it also includes Spark 3.0.0; Hudi requires 2.x.Relocating Jetty during packaging solves the problem and allows Hudi to operate with its own version, independent of what Databricks provides. This allows
hudi-spark-bundleto work within Databricks out-of-the-box with no further alterations.Brief change log
packaging/hudi-spark-bundle/pom.xmlto relocate Jetty during packagingVerify this pull request
This pull request is a trivial rework / code cleanup without any test coverage. There are no modifications to code functionality.
Committer checklist
Has a corresponding JIRA in PR title & commit (used
[MINOR]tag due to simple nature of the change)Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.