Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CompletedFileSystemView instead of CompactedView considering deltacommits too #229

Merged
merged 1 commit into from Aug 7, 2017
Merged

Use CompletedFileSystemView instead of CompactedView considering deltacommits too #229

merged 1 commit into from Aug 7, 2017

Conversation

n3nash
Copy link
Contributor

@n3nash n3nash commented Jul 27, 2017

@vinothchandar The clean() API uses getCompactedFileSystemView() which basically returns either commit for COW or compaction for MOR. If the timeline for MOR does not have any compaction and has only deltacommits we should not throw an exception.

vinothchandar
vinothchandar approved these changes Aug 3, 2017
View reviewed changes
Copy link
Member

@vinothchandar vinothchandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (I think).. Can you clarify what this is fixing?

@vinothchandar vinothchandar merged commit 5ee4ac4 into apache:master Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinothchandar vinothchandar vinothchandar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@n3nash @vinothchandar