Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nested fields support for MOR tables #234

Merged
merged 1 commit into from Aug 16, 2017

Conversation

jianxu
Copy link
Contributor

@jianxu jianxu commented Aug 3, 2017

This fixes #208.

Copy link
Member

@vinothchandar vinothchandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a quick pass. Does projecting nested fields e.g: a.b.c work now?

@jianxu
Copy link
Contributor Author

jianxu commented Aug 3, 2017

yes, nested fields work and tested in a local HDFS setup. Hive will read the entire column for a if a.b or a.b.c is queries.

@prazanna
Copy link
Contributor

prazanna commented Aug 4, 2017

Looks good to me! Congrats @jianxu on your first contribution

@prazanna prazanna self-requested a review August 4, 2017 20:29
@vinothchandar
Copy link
Member

vinothchandar commented Aug 7, 2017

Ideally, we need the following matrix tested well, before we can call this support done.

Engine Map datatype Array/List data type Nested projection
Spark
Hive
Presto

@vinothchandar
Copy link
Member

I am pulling this in for now.. @jianxu please follow up on testing above, if you intend to continue working on this.

@vinothchandar vinothchandar merged commit b1cf097 into apache:master Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for nested fields in queries on Merge-on-read tables
3 participants