[HUDI-1160] Support update partial fields for CoW table #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2386 +/- ##
=============================================
- Coverage 52.23% 10.04% -42.19%
+ Complexity 2662 48 -2614
=============================================
Files 335 52 -283
Lines 14981 1852 -13129
Branches 1506 223 -1283
=============================================
- Hits 7825 186 -7639
+ Misses 6533 1653 -4880
+ Partials 623 13 -610
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@leesf please review ,thanks |
leesf
reviewed
Dec 28, 2020
Comment on lines
+67
to
+70
| List<HoodieRecord> inserts2 = | ||
| dataGen.generatePartialUpdateInsertsStream(commitTime2, 100, false, PARTIAL_TRIP_SCHEMA, false).collect(Collectors.toList()); // this writes ~500kb | ||
| List<HoodieKey> insertKeys2 = recordsToHoodieKeys(inserts2); | ||
| WriteStatus writeStatus = upsertAndCheck(client, insertKeys2, commitTime2, true); |
There was a problem hiding this comment.
if users use this payload, and adding some fields in commits, what will happen? would you please add a test for this case?
There was a problem hiding this comment.
For MOR table, and any other changes to make MOR partial update works?
leesf
reviewed
Dec 28, 2020
| dataGen.generatePartialUpdateInsertsStream(commitTime1, 100, false, TRIP_SCHEMA, false).collect(Collectors.toList()); // this writes ~500kb | ||
| List<HoodieKey> insertKeys1 = recordsToHoodieKeys(inserts1); | ||
| upsertAndCheck(client, insertKeys1, commitTime1, false); | ||
|
|
leesf
reviewed
Dec 28, 2020
| List<String> oldSchemaFieldNames = AVRO_TRIP_SCHEMA.getFields().stream().map(Schema.Field::name).collect(Collectors.toList()); | ||
| List<String> parquetFieldNames = schema.getFields().stream().map(Schema.Field::name).collect(Collectors.toList()); | ||
|
|
||
|
|
leesf
reviewed
Dec 28, 2020
| @@ -461,6 +494,11 @@ public static void createSavepointFile(String basePath, String instantTime, Conf | |||
| () -> UUID.randomUUID().toString()); | |||
| } | |||
|
|
|||
| public Stream<HoodieRecord> generatePartialUpdateInsertsStream(String commitTime, Integer n, boolean isFlattened, String schemaStr, boolean containsAllPartitions) { | |||
There was a problem hiding this comment.
please split the parameters into two lines.
leesf
reviewed
Dec 28, 2020
| @@ -486,6 +524,28 @@ public static void createSavepointFile(String basePath, String instantTime, Conf | |||
| }); | |||
| } | |||
|
|
|||
| public Stream<HoodieRecord> generatePartialUpdateInsertsStream(String instantTime, Integer n, boolean isFlattened, String schemaStr, boolean containsAllPartitions, | |||
leesf
reviewed
Dec 28, 2020
| + "{\"name\":\"driver\",\"type\":\"string\"},{\"name\":\"fare\",\"type\":\"double\"},{\"name\": \"_hoodie_is_deleted\", \"type\": \"boolean\", " | ||
| + "\"default\": false}]}"; | ||
|
|
||
| public static final String PARTIAL_TRIP_SCHEMA = "{\"type\":\"record\",\"name\":\"tripUberRec\",\"fields\":[{\"name\":\"timestamp\",\"type\":\"long\"},{\"name\":\"_row_key\",\"type\":\"string\"}," |
|
hi @liujinhui1994 ,a liitle concern. |
|
@Karl-WangSK Can you describe it in detail？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
Support update partial fields for Cow table
Brief change log
Support update partial fields for Cow table, currently, when updating hudi table, users have to provide all fields, however in some cases, users would not provide all fields, and hudi needs to support update partial fields.
Introduce PartialUpdatePayload
Verify this pull request
Add UTs
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.