New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deprecated hash function #259
Update deprecated hash function #259
Conversation
Guava deprecated hashString(String) in v15, and removed it in v16. Replace call with hashUnencodedString(String), which replace it, to be compatible with newer versions of Guava.
@vinothchandar , @n3nash FYI. |
Happy to pull this.. but fyi
|
I am afraid we have a problem. Spark is still on 14.0 and a job fails as below.
I am going to revert this change. Can you comment on how you got this tested? I am using Spark 2.1 |
@esmioley ^^ |
We're using a spark build running with guava 16 (which is why it was failing in the first place, requiring a change) |
when you say spark build, is this our own spark library build or final jar given to spark-submit has guava 16. |
Co-authored-by: Y Ethan Guo <ethan.guoyihua@gmail.com> Co-authored-by: 苏承祥 <1142819049@qq.com> Co-authored-by: 苏承祥 <sucx@tuya.com> Co-authored-by: Danny Chan <yuzhao.cyz@gmail.com> Co-authored-by: Alexey Kudinkin <alexey.kudinkin@gmail.com> Co-authored-by: harshal <harshal.j.patil@gmail.com> Co-authored-by: Pramod Biligiri <pramodbiligiri@gmail.com> Co-authored-by: huangxiaoping <35296098+huangxiaopingRD@users.noreply.github.com> Co-authored-by: Teng <teng_huo@outlook.com> Co-authored-by: zhuanshenbsj1 <34104400+zhuanshenbsj1@users.noreply.github.com> Co-authored-by: Rahil C <32500120+rahil-c@users.noreply.github.com> Co-authored-by: Rahil Chertara <rchertar@amazon.com> Co-authored-by: Balaji Varadarajan <balaji.varadarajan@robinhood.com> Co-authored-by: Nicholas Jiang <programgeek@163.com> Co-authored-by: Sagar Sumit <sagarsumit09@gmail.com> Co-authored-by: sandyfog <154525105@qq.com> Co-authored-by: Shiyan Xu <2701446+xushiyan@users.noreply.github.com> Co-authored-by: Manu <36392121+xicm@users.noreply.github.com> Co-authored-by: Bingeng Huang <304979636@qq.com> Co-authored-by: hbg <bingeng.huang@shopee.com> Co-authored-by: Tim Brown <tim@onehouse.ai> Co-authored-by: Lokesh Jain <ljain@apache.org> Co-authored-by: rfyu <39233058+rfyu@users.noreply.github.com> Co-authored-by: Raymond Xu <xu.shiyan.raymond@gmail.com>
Guava deprecated hashString(String) in v15, and removed it in v16.
Replace call with hashUnencodedString(String), which replace it, to
be compatible with newer versions of Guava.