Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-1692] Bounded source for stream writer #2674

Merged
merged 1 commit into from Mar 15, 2021

Conversation

danny0405
Copy link
Contributor

Supports bounded source such as VALUES for stream mode writer.

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Supports bounded source such as VALUES for stream mode writer.
@codecov-io
Copy link

codecov-io commented Mar 15, 2021

Codecov Report

Merging #2674 (8419357) into master (fc6c5f4) will increase coverage by 0.06%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2674      +/-   ##
============================================
+ Coverage     51.96%   52.03%   +0.06%     
- Complexity     3579     3580       +1     
============================================
  Files           466      466              
  Lines         22275    22294      +19     
  Branches       2374     2374              
============================================
+ Hits          11576    11601      +25     
+ Misses         9690     9685       -5     
+ Partials       1009     1008       -1     
Flag Coverage Δ Complexity Δ
hudicli 37.01% <ø> (ø) 0.00 <ø> (ø)
hudiclient 100.00% <ø> (ø) 0.00 <ø> (ø)
hudicommon 51.46% <ø> (+0.01%) 0.00 <ø> (ø)
hudiflink 53.96% <83.33%> (+0.39%) 0.00 <4.00> (ø)
hudihadoopmr 33.44% <ø> (ø) 0.00 <ø> (ø)
hudisparkdatasource 69.84% <ø> (ø) 0.00 <ø> (ø)
hudisync 49.62% <ø> (ø) 0.00 <ø> (ø)
huditimelineservice 64.36% <ø> (ø) 0.00 <ø> (ø)
hudiutilities 69.48% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...g/apache/hudi/sink/StreamWriteOperatorFactory.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ache/hudi/sink/StreamWriteOperatorCoordinator.java 69.37% <20.00%> (+0.23%) 32.00 <0.00> (ø)
...in/java/org/apache/hudi/table/HoodieTableSink.java 14.28% <50.00%> (-2.39%) 2.00 <1.00> (ø)
...java/org/apache/hudi/sink/StreamWriteFunction.java 85.04% <90.90%> (+1.04%) 22.00 <0.00> (ø)
...apache/hudi/sink/event/BatchWriteSuccessEvent.java 92.30% <100.00%> (+6.59%) 9.00 <3.00> (+1.00)
...java/org/apache/hudi/table/HoodieTableFactory.java 76.92% <100.00%> (ø) 5.00 <0.00> (ø)
...e/hudi/common/table/log/HoodieLogFormatWriter.java 79.68% <0.00%> (+1.56%) 26.00% <0.00%> (ø%)

@yanghua yanghua self-assigned this Mar 15, 2021
@yanghua yanghua self-requested a review March 15, 2021 11:33
Copy link
Contributor

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanghua yanghua merged commit 76bf2cc into apache:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants