Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-1785] Move OperationConverter to hudi-client-common for code reuse #2798

Merged
merged 1 commit into from Apr 12, 2021

Conversation

wangxianghu
Copy link
Contributor

Tips

What is the purpose of the pull request

Currently, OperationConverter has been introduced twice in hudi-flink and hudi-utilities module, we can move it to hudi-client-common, so it can be used in both of them

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@codecov-io
Copy link

codecov-io commented Apr 10, 2021

Codecov Report

Merging #2798 (81fd3bb) into master (18459d4) will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2798      +/-   ##
============================================
+ Coverage     52.26%   52.56%   +0.29%     
- Complexity     3682     3708      +26     
============================================
  Files           484      484              
  Lines         23094    23167      +73     
  Branches       2456     2459       +3     
============================================
+ Hits          12070    12177     +107     
+ Misses         9959     9919      -40     
- Partials       1065     1071       +6     
Flag Coverage Δ Complexity Δ
hudicli 40.29% <ø> (+3.35%) 0.00 <ø> (ø)
hudiclient ∅ <ø> (∅) 0.00 <ø> (ø)
hudicommon 50.67% <ø> (-0.10%) 0.00 <ø> (ø)
hudiflink 56.60% <ø> (+0.02%) 0.00 <ø> (ø)
hudihadoopmr 33.44% <ø> (ø) 0.00 <ø> (ø)
hudisparkdatasource 71.33% <ø> (ø) 0.00 <ø> (ø)
hudisync 45.70% <ø> (+0.23%) 0.00 <ø> (ø)
huditimelineservice 64.36% <ø> (ø) 0.00 <ø> (ø)
hudiutilities 69.84% <ø> (+0.12%) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../org/apache/hudi/streamer/FlinkStreamerConfig.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...i/utilities/deltastreamer/HoodieDeltaStreamer.java 71.78% <ø> (+0.59%) 18.00 <0.00> (ø)
...s/deltastreamer/HoodieMultiTableDeltaStreamer.java 78.39% <ø> (ø) 18.00 <0.00> (ø)
.../apache/hudi/sink/compact/CompactionPlanEvent.java 50.00% <0.00%> (-50.00%) 3.00% <0.00%> (ø%)
...pache/hudi/sink/compact/CompactionCommitEvent.java 43.75% <0.00%> (-43.75%) 3.00% <0.00%> (ø%)
...i/common/table/timeline/TimelineMetadataUtils.java 70.17% <0.00%> (-2.56%) 17.00% <0.00%> (ø%)
...he/hudi/sink/partitioner/BucketAssignFunction.java 85.18% <0.00%> (-2.49%) 17.00% <0.00%> (+2.00%) ⬇️
...in/java/org/apache/hudi/table/HoodieTableSink.java 11.90% <0.00%> (-0.30%) 2.00% <0.00%> (ø%)
.../common/table/timeline/HoodieArchivedTimeline.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...he/hudi/hive/HiveStylePartitionValueExtractor.java 100.00% <0.00%> (ø) 3.00% <0.00%> (?%)
... and 5 more

@yanghua yanghua self-assigned this Apr 10, 2021
@yanghua yanghua self-requested a review April 10, 2021 05:08
Copy link
Contributor

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanghua yanghua merged commit 040756d into apache:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants