Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-1979] Optimize logic to improve code readability #3037

Merged
merged 1 commit into from Jun 5, 2021

Conversation

chaplinthink
Copy link
Contributor

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2021

Codecov Report

Merging #3037 (0152412) into master (c2383ee) will decrease coverage by 15.70%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #3037       +/-   ##
=============================================
- Coverage     70.83%   55.12%   -15.71%     
- Complexity      385     3864     +3479     
=============================================
  Files            54      487      +433     
  Lines          2016    23605    +21589     
  Branches        241     2528     +2287     
=============================================
+ Hits           1428    13012    +11584     
- Misses          454     9433     +8979     
- Partials        134     1160     +1026     
Flag Coverage Δ
hudicli 39.55% <ø> (?)
hudiclient ∅ <ø> (∅)
hudicommon 50.31% <ø> (?)
hudiflink 63.25% <ø> (?)
hudihadoopmr 51.43% <ø> (?)
hudisparkdatasource 74.28% <ø> (?)
hudisync 46.60% <0.00%> (?)
huditimelineservice 64.36% <ø> (?)
hudiutilities 70.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ache/hudi/hive/HiveMetastoreBasedLockProvider.java 0.00% <0.00%> (ø)
...he/hudi/sink/partitioner/profile/WriteProfile.java 85.93% <0.00%> (ø)
...in/scala/org/apache/hudi/HoodieEmptyRelation.scala 66.66% <0.00%> (ø)
...java/org/apache/hudi/hive/util/HiveSchemaUtil.java 68.93% <0.00%> (ø)
...penJ9MemoryLayoutSpecification64bitCompressed.java 0.00% <0.00%> (ø)
...mon/table/log/block/HoodieCommandBlockVersion.java 0.00% <0.00%> (ø)
...g/apache/hudi/common/bloom/BloomFilterFactory.java 54.54% <0.00%> (ø)
.../src/main/java/org/apache/hudi/dla/util/Utils.java 0.00% <0.00%> (ø)
...apache/hudi/sink/event/BatchWriteSuccessEvent.java 92.30% <0.00%> (ø)
...e/hudi/sink/transform/RowDataToHoodieFunction.java 100.00% <0.00%> (ø)
... and 424 more

@leesf leesf merged commit dab13f7 into apache:master Jun 5, 2021
@chaplinthink chaplinthink deleted the dev branch June 6, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants