Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-1990] Delete duplicate BootstrapFunction #3052

Merged
merged 1 commit into from Jun 9, 2021

Conversation

yuzhaojing
Copy link
Contributor

Tips

What is the purpose of the pull request

delete duplicate BootstrapFunction operator in HoodieTableSink.

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@yuzhaojing
Copy link
Contributor Author

@danny0405 @wangxianghu please review this fix, thanks.

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2021

Codecov Report

Merging #3052 (51fd22a) into master (11360f7) will decrease coverage by 2.78%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3052      +/-   ##
============================================
- Coverage     55.35%   52.56%   -2.79%     
+ Complexity     4026      404    -3622     
============================================
  Files           520       69     -451     
  Lines         25293     2863   -22430     
  Branches       2872      358    -2514     
============================================
- Hits          14000     1505   -12495     
+ Misses         9907     1215    -8692     
+ Partials       1386      143    -1243     
Flag Coverage Δ
hudicli ?
hudiclient ?
hudicommon ?
hudiflink ?
hudihadoopmr ?
hudisparkdatasource ?
hudisync 6.79% <ø> (-44.66%) ⬇️
huditimelineservice ?
hudiutilities 71.06% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../org/apache/hudi/hive/NonPartitionedExtractor.java 0.00% <0.00%> (-100.00%) ⬇️
...he/hudi/hive/HiveStylePartitionValueExtractor.java 0.00% <0.00%> (-100.00%) ⬇️
...main/java/org/apache/hudi/hive/HiveSyncConfig.java 0.00% <0.00%> (-97.83%) ⬇️
.../apache/hudi/hive/MultiPartKeysValueExtractor.java 0.00% <0.00%> (-90.91%) ⬇️
...in/java/org/apache/hudi/hive/SchemaDifference.java 0.00% <0.00%> (-84.85%) ⬇️
...in/java/org/apache/hudi/hive/util/ConfigUtils.java 0.00% <0.00%> (-73.92%) ⬇️
...in/java/org/apache/hudi/hive/HoodieHiveClient.java 0.00% <0.00%> (-71.61%) ⬇️
...va/org/apache/hudi/hive/util/ColumnNameXLator.java 0.00% <0.00%> (-70.00%) ⬇️
...java/org/apache/hudi/hive/util/HiveSchemaUtil.java 0.00% <0.00%> (-68.94%) ⬇️
...c/main/java/org/apache/hudi/hive/HiveSyncTool.java 0.00% <0.00%> (-67.55%) ⬇️
... and 449 more

Copy link
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, can we log an issue and bing the PR with it.

@yuzhaojing
Copy link
Contributor Author

yuzhaojing commented Jun 9, 2021

+1, can we log an issue and bing the PR with it.

ok

@yuzhaojing yuzhaojing changed the title Delete duplicate BootstrapFunction [HUDI-1990] Delete duplicate BootstrapFunction Jun 9, 2021
@danny0405
Copy link
Contributor

I have added some cosmetic fix, please also fix it.

@yuzhaojing
Copy link
Contributor Author

I have added some cosmetic fix, please also fix it.

Thanks for cosmetic fix, already fix in this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants