New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-1990] Delete duplicate BootstrapFunction #3052
Conversation
@danny0405 @wangxianghu please review this fix, thanks. |
Codecov Report
@@ Coverage Diff @@
## master #3052 +/- ##
============================================
- Coverage 55.35% 52.56% -2.79%
+ Complexity 4026 404 -3622
============================================
Files 520 69 -451
Lines 25293 2863 -22430
Branches 2872 358 -2514
============================================
- Hits 14000 1505 -12495
+ Misses 9907 1215 -8692
+ Partials 1386 143 -1243
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, can we log an issue and bing the PR with it.
ok |
I have added some cosmetic fix, please also fix it. |
Thanks for cosmetic fix, already fix in this pr. |
Tips
What is the purpose of the pull request
delete duplicate BootstrapFunction operator in HoodieTableSink.
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.