-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-2191] Bump flink version to 1.13.1 #3291
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3291 +/- ##
============================================
+ Coverage 47.83% 47.84% +0.01%
- Complexity 5565 5567 +2
============================================
Files 936 936
Lines 41663 41662 -1
Branches 4197 4195 -2
============================================
+ Hits 19929 19933 +4
+ Misses 19960 19955 -5
Partials 1774 1774
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@danny0405 Most users do not have 1.13 in their production environment I believe. What benefit of this upgrade brings to us? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should do this upgrade before the release unless we do a better job on version compatibility.
The Amazon AWS EMR and Aliyun EMR next version all need this patch for the flink hudi integration. |
Is there any way we can make Hudi compatible with both Flink 1.12 and 1.13? Many users still have <1.12 in their production environment AFAIK. |
The Flink interface compatibility between minor version is a shit, not to say major version, it's hard to be compatible for both 1.12 and 1.13. I guess the flink compatibility would be better from 1.14. |
@danny0405 I think we should at least support 1.12 for the 0.9.0 release, if you think this upgrade is necessary, I'd recommend support both 1.12 and 1.13. Maybe we can have a V1 and V2 connector? |
I'm planning to upgrade the version to 1.12.3 for 0.9.0 release and after the release upgrade it to 1.13.1. |
@danny0405 What's the impact of upgrading from 1.12.2 to 1.12.3? we should be very cautious about the version upgrade unless they are fully backward compatible. |
@garyli1019 something are not work well, like pulsar sql connector https://search.maven.org/artifact/io.streamnative.connectors/pulsar-flink-sql-connector_2.11 |
Hi @haormj , what do you mean something is not working well? Do you mean you need Flink 1.13 to use the Flink pulsar connector? |
@garyli1019 now I use 1.12.2 + hudi master, but I can not use pulsar sql connector, I suspect it was caused by flink 1.12.2, and I attempt to merge this change and retry it I just found pulsar-flink-sql-connector 1.12.3, 1.12.4 and 1.13.1 |
@garyli1019 hudi + flink 1.13.1 + pulsar-flink-sql-connector_2.11-1.13.1.1.jar works well, but I not try 1.12.3, 1.12.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Tips
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.