Add more options in HoodieWriteConfig #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinothchandar
requested changes
Mar 12, 2018
| @@ -58,6 +58,8 @@ | |||
| private static final String DEFAULT_ASSUME_DATE_PARTITIONING = "false"; | |||
| private static final String HOODIE_WRITE_STATUS_CLASS_PROP = "hoodie.writestatus.class"; | |||
| private static final String DEFAULT_HOODIE_WRITE_STATUS_CLASS = WriteStatus.class.getName(); | |||
| private static final String INPUT_RECORD_STORAGE_LEVEL = "hoodie.input.record.storage.level"; | |||
| private static final String DEFAULT_INPUT_RECORD_STORAGE_LEVEL = "MEMORY_AND_DISK_SER"; | |||
There was a problem hiding this comment.
This must be a BloomIndex level config, since other indexes won't respect it anyway. lets move to HoodieIndexConfig
lets rename to hoodie.bloom.index.input.storage.level and relevant methods as well
There was a problem hiding this comment.
Good point, will update.
jianxu
force-pushed
the
jian/more-configs
branch
from
0f946ed
to
e20763a
Compare
jianxu
force-pushed
the
jian/more-configs
branch
from
e20763a
to
184d3e9
Compare
|
@vinothchandar A new config |
vinishjail97
pushed a commit
to vinishjail97/hudi
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding two more options in HoodieWriteConfig.
inttolong.withInputRecordStorageLevel, so thatHoodieBloomIndexcan persist the input record using user's configuration.