Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-2288] Support storage on ks3 for hudi #3434

Merged
merged 6 commits into from Aug 10, 2021
Merged

[HUDI-2288] Support storage on ks3 for hudi #3434

merged 6 commits into from Aug 10, 2021

Conversation

xuzifu666
Copy link
Contributor

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot
Copy link

hudi-bot commented Aug 9, 2021

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run travis re-run the last Travis build
  • @hudi-bot run azure re-run the last Azure build

@xuzifu666
Copy link
Contributor Author

support s3 storage (Kingsoft Standard Storage Service) for hudi @leesf

@@ -46,6 +46,7 @@ public void testStorageSchemes() {
assertFalse(StorageSchemes.isAppendSupported("dbfs"));
assertFalse(StorageSchemes.isAppendSupported("cos"));
assertFalse(StorageSchemes.isAppendSupported("bos"));
assertFalse(StorageSchemes.isAppendSupported("ks3"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the indent was off here

@danny0405
Copy link
Contributor

Please fire a JIRA issue and change the title to "[HUDI-xxx] you commit message"

@vinothchandar vinothchandar added this to Ready for Review in PR Tracker Board Aug 10, 2021
@xuzifu666 xuzifu666 changed the title support ks3 storage for hudi [HUDI-2288] support storage on ks3 for hudi Aug 10, 2021
@xuzifu666
Copy link
Contributor Author

@hudi-bot run azure

@yanghua yanghua changed the title [HUDI-2288] support storage on ks3 for hudi [HUDI-2288] Support storage on ks3 for hudi Aug 10, 2021
@xuzifu666

This comment has been minimized.

3 similar comments
@xuzifu666

This comment has been minimized.

@xuzifu666

This comment has been minimized.

@xuzifu666
Copy link
Contributor Author

@hudi-bot run azure

@xuzifu666
Copy link
Contributor Author

@hudi-bot run travis

@xuzifu666
Copy link
Contributor Author

@hudi-bot run azure

@xuzifu666
Copy link
Contributor Author

@hudi-bot run azure

PR Tracker Board automation moved this from Ready for Review to Nearing Landing Aug 10, 2021
@leesf leesf merged commit a18bc83 into apache:master Aug 10, 2021
PR Tracker Board automation moved this from Nearing Landing to Done Aug 10, 2021
liujinhui1994 pushed a commit to liujinhui1994/hudi that referenced this pull request Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants