New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-2288] Support storage on ks3 for hudi #3434
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support s3 storage (Kingsoft Standard Storage Service) for hudi @leesf |
garyli1019
requested changes
Aug 9, 2021
@@ -46,6 +46,7 @@ public void testStorageSchemes() { | |||
assertFalse(StorageSchemes.isAppendSupported("dbfs")); | |||
assertFalse(StorageSchemes.isAppendSupported("cos")); | |||
assertFalse(StorageSchemes.isAppendSupported("bos")); | |||
assertFalse(StorageSchemes.isAppendSupported("ks3")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the indent was off here
garyli1019
approved these changes
Aug 9, 2021
Please fire a JIRA issue and change the title to "[HUDI-xxx] you commit message" |
xuzifu666
changed the title
support ks3 storage for hudi
[HUDI-2288] support storage on ks3 for hudi
Aug 10, 2021
@hudi-bot run azure |
yanghua
changed the title
[HUDI-2288] support storage on ks3 for hudi
[HUDI-2288] Support storage on ks3 for hudi
Aug 10, 2021
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@hudi-bot run azure |
@hudi-bot run travis |
@hudi-bot run azure |
@hudi-bot run azure |
leesf
approved these changes
Aug 10, 2021
liujinhui1994
pushed a commit
to liujinhui1994/hudi
that referenced
this pull request
Aug 12, 2021
Co-authored-by: xuzifu <xuzifu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.