HUDI-2491 hoodie.datasource.hive_sync.mode=hms mode is supported in s… #3722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…park writer option
|
@codope : Can you take up this review please. |
|
@nsivabalan Thank you for your comments, but I don't know where the mistake is. I'm a novice |
codope
reviewed
Oct 11, 2021
There was a problem hiding this comment.
@fuyun2024 Thanks for the contribution. It will be a useful addition to the hive sync. Could you please address some of the comments?
| @@ -381,6 +381,11 @@ object DataSourceWriteOptions { | |||
| val HIVE_URL: ConfigProperty[String] = ConfigProperty | |||
| .key("hoodie.datasource.hive_sync.jdbcurl") | |||
| .defaultValue("jdbc:hive2://localhost:10000") | |||
| .withDocumentation("Hive jdbc url") | |||
|
|
|||
| val METASTOR_URIS: ConfigProperty[String] = ConfigProperty | |||
| .withDocumentation("Hive jdbc url") | ||
|
|
||
| val METASTOR_URIS: ConfigProperty[String] = ConfigProperty | ||
| .key("hoodie.datasource.hive_sync.metastore.uris") |
There was a problem hiding this comment.
Let's have consistency with DeltaStreamer. There should be a way to set this config with deltastreamer as well.
There was a problem hiding this comment.
Perhaps we need to set this config in DataSourceUtils#buildHiveSyncConfig. Please check.
| @@ -517,6 +517,9 @@ object HoodieSparkSqlWriter { | |||
| val hiveSyncConfig: HiveSyncConfig = buildSyncConfig(basePath, hoodieConfig, sqlConf) | |||
| val hiveConf: HiveConf = new HiveConf() | |||
| hiveConf.addResource(fs.getConf) | |||
| if(!DataSourceWriteOptions.METASTOR_URIS.defaultValue.equals(hiveSyncConfig.metastoreUris)){ | |||
There was a problem hiding this comment.
Can you please add a test case in the writer test suite or elsewhere to cover this scenario?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…park writer option
Tips
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.