New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-3148] Create pushgateway client based on port #4497
Conversation
private PushGateway createPushGatewayClient(String serverHost, int serverPort) { | ||
if (serverPort == 443) { | ||
try { | ||
return new PushGateway(new URL("https://" + serverHost)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@t0il3ts0ap : Did you test this patch?
don't we need
new URL("https://" + serverHost + ":" + serverPort));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nsivabalan Srry, couldnt reply in time. Yes this is tested, its not needed. Shouldn't be an issue, even if added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small clarification. Can land once clarified.
@t0il3ts0ap : sorry do you know if suffixing the port would work or fail? I did not get a chance to test it out, but suffixed the port and merged it in. |
Co-authored-by: anoop narang <anoop.narang@navi.com> Co-authored-by: sivabalan narayanan <n.siva.b@gmail.com>
Co-authored-by: anoop narang <anoop.narang@navi.com> Co-authored-by: sivabalan narayanan <n.siva.b@gmail.com>
Co-authored-by: anoop narang <anoop.narang@navi.com> Co-authored-by: sivabalan narayanan <n.siva.b@gmail.com>
Tips
What is the purpose of the pull request
#4496
Fix above issue
Brief change log
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.