New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HUDI-1657: build failed on AArch64, Fedora 33 #4617
Conversation
Fix the build Hudi on Arm64 Fedora33. Change-Id: I4795f5b0483521bfdc419b84f3b99faff4b3a847 Signed-off-by: Yuqi Gu <guyuqi@apache.org>
Successfully build Hudi on Arm64 Fedora33/Ubuntu20:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @guyuqi Could you run the Quick Start Guide for Kafka Connect Sink for Hudi to make sure the Sink functionality is not affected?
Thanks for your comments. From Quick Start Guide, Enviroments:
1. Successfully Create the Hudi Topic for the Sink and insert data into the topic:
2. Run the Sink connector worker
|
@guyuqi Have you verified that the Hudi table written by the sink can be successfully read? |
sure, thanks! no probs. |
@guyuqi : Is there any updates for us. We plan to get this into 0.11. Thats why being pushy. sorry about that. |
I put everything in a Fedora-33 docker container for I have no Fedora-33 host. But when add the Hudi Sink to the Connector:
jps:
ifconfig:
For I'm the new comer to Hudi, I have no idea how to change This PR is just to upgrade the Protocbuf from 3.1 to 3.11. Is there any simple unitest case for it instead of this complicated demo for the new comer ? |
@guyuqi I'll test the sink on my side as well. For changing the IP address, could you do
You may also hardcode the IP address of the host instead of |
I followed the Quick Start Guide for Kafka Connect Sink for Hudi and verified that the Hudi table written by the sink can be successfully read through Spark datasource on my x86_64 macbook. @guyuqi When you get a chance, could you report your testing on aarch64 machine after fixing the hostname issue? I'm going to merge this PR for now. Feel free to follow up with any fixes needed. |
Tips
What is the purpose of the pull request
Fix the build Hudi on Arm64 Fedora33.
Protocbuf did not support Arm64 until Protobuf 3.5.0.
So we should upgrade Protoc dependency for fix the build issues:
Brief change log
Upgrade dependency in pom.xml
Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.