[HUDI-3720] Fix the logic of reattempting pending rollback #5148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
When reattempting a pending rollback and the instant to rollback does not exist in the active timeline anymore due to a failure just before the rollback was transitioned from inflight to complete, such rollback cannot successfully be completed. This PR fixes the logic so that in such case the rollback can be reattempted successfully.
Brief change log
BaseHoodieWriteClient
.TestClientRollback
.Verify this pull request
This change added tests in
TestClientRollback
and is verified as follows:Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.