[HUDI-3936] Fix projection for a nested field as pre-combined key #5379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xushiyan
reviewed
Apr 21, 2022
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSparkUtils.scala
Outdated
Show resolved
Hide resolved
nsivabalan
approved these changes
Apr 21, 2022
| // For a nested field in mandatory columns, we should first get the root-level field, and then | ||
| // check for any missing column, as the requestedColumns should only contain root-level fields | ||
| // We should only append root-level field as well | ||
| val missing = mandatoryColumns.map(col => HoodieAvroUtils.getRootLevelFieldName(col)) |
There was a problem hiding this comment.
Let's do this filtering when we assign it (name mandatoryColumns is misleading otherwise)
There was a problem hiding this comment.
If I understand it correctly, do you mean to say we can do the filtering of mandatoryColumns upon initialization of the class? That's not possible since we need to do on-the-fly filtering based on the passed-in requestedColumns which may vary when buildScan is called.
There was a problem hiding this comment.
i think Alexey meant a readability improvement
xiarixiaoyao
approved these changes
Apr 21, 2022
xushiyan
force-pushed
the
HUDI-3936-fix-nested-field-precombine-key
branch
from
dd8db55
to
d24bcd6
Compare
xushiyan
approved these changes
Apr 21, 2022
yihua
force-pushed
the
HUDI-3936-fix-nested-field-precombine-key
branch
from
d24bcd6
to
8d5d576
Compare
nsivabalan
force-pushed
the
HUDI-3936-fix-nested-field-precombine-key
branch
from
8d5d576
to
5aae2f9
Compare
|
@hudi-bot run azure |
1 similar comment
|
@hudi-bot run azure |
nsivabalan
pushed a commit
that referenced
this pull request
Apr 22, 2022
) This PR fixes the projection logic around a nested field which is used as the pre-combined key field. The fix is to only check and append the root level field for projection, i.e., "a", for a nested field "a.b.c" in the mandatory columns. - Changes the logic to check and append the root level field for a required nested field in the mandatory columns in HoodieBaseRelation.appendMandatoryColumns
xushiyan
pushed a commit
that referenced
this pull request
Apr 22, 2022
) This PR fixes the projection logic around a nested field which is used as the pre-combined key field. The fix is to only check and append the root level field for projection, i.e., "a", for a nested field "a.b.c" in the mandatory columns. - Changes the logic to check and append the root level field for a required nested field in the mandatory columns in HoodieBaseRelation.appendMandatoryColumns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
This PR fixes the projection logic around a nested field which is used as the pre-combined key field. The fix is to only check and append the root level field for projection, i.e., "a", for a nested field "a.b.c" in the mandatory columns.
Brief change log
HoodieBaseRelation.appendMandatoryColumnsVerify this pull request
This change adds tests in
TestHoodieAvroUtilsandTestMORDataSourceStorage.TestMORDataSourceStoragecontains tests that use nested field "fare.currency" as the pre-combined key. Before this change, the tests with nest fields fail. After this PR, the tests pass.Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.