[HUDI-4194] upgrade confluent version to 7.1.1 #5758
+17
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorxiang30
force-pushed
the
confluent-upgrade
branch
from
7f35c09
to
c7ed975
Compare
nsivabalan
added
dependencies
|
@yihua : can you review this PR. |
victorxiang30
force-pushed
the
confluent-upgrade
branch
from
c7ed975
to
7baa719
Compare
yihua
reviewed
Jun 10, 2022
There was a problem hiding this comment.
@victorxiang30 Thanks for your first contribution. Could you check the CI failure?
Comment on lines
145
to
+149
| HiveIncrementalPuller puller = new HiveIncrementalPuller(getHivePullerConfig( | ||
| "select name from testdb.test1")); | ||
| Exception e = assertThrows(HoodieIncrementalPullSQLException.class, puller::saveDelta, | ||
| "Should fail when incremental clause not provided!"); | ||
| assertTrue(e.getMessage().contains("Incremental SQL does not have clause `_hoodie_commit_time` > '%s', which means its not pulling incrementally")); | ||
| "select name from testdb.test1")); | ||
| Exception e = assertThrows(HoodieIncrementalPullException.class, puller::saveDelta, | ||
| "Failed to get data location for table testdb.test1"); | ||
| assertTrue(e.getMessage().contains("Failed to get data location for table")); |
There was a problem hiding this comment.
Why does the error change? Is something else broken?
|
@victorxiang30 : can you respond to Ethan's clarifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.