[HUDI-4396] Add a boolean parameter to decide whether the partition is cascade or not when hive table columns changes #6139
Conversation
honeyaya
changed the title
|
@hudi-bot |
|
@yihua could you help me review this pr? thanks. |
|
@hudi-bot run azure |
| @Parameter(names = {"--partition-cascade"}, description = "Partition cascade when table columns change.") | ||
| public Boolean partitionCascade; |
There was a problem hiding this comment.
in general we should avoid adding parameters/configs to tweak the logic inside the sync. There are so many configs already exposing the impl. details and making meta sync hard to use.
For this logic of determining cascade, can you figure out a way to detect it from schema/column changes?
There was a problem hiding this comment.
Hi, good idea about the configs settings.
And the logic cascade could not be detected from schema/column changes as far as I think, but the table parameters might help set this config in my opinion, then the user needs to create/alter the table with TBLPROPERTIES: "hoodie.datasource.hive_sync.partition_cascade=false" through HiveSQL, and this is not directly to use.
If we compare these two plans, I prefer the original plan, then what's your opinion?
yihua
added
meta-sync
priority:major
What is the purpose of the pull request
Add a boolean parameter to decide whether the partition is cascade or not when hive table columns changes
Brief change log
Verify this pull request
This pull request is already covered by existing tests, the default value of the the parameter is true
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.