-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-4558] lost 'hoodie.table.keygenerator.class' in hoodie.properties #6320
Merged
danny0405
merged 3 commits into
apache:master
from
wuwenchi:read_KEYGEN_CLASS_NAME_from_KEYGEN_TYPE
Aug 10, 2022
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can giving the option
KEYGEN_CLASS_NAME
a default value:SimpleAvroKeyGenerator
solves your problem ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you set the
KEYGEN_CLASS_NAME
default value, it does solve the problem of not showing.However, in the original logic, if
KEYGEN_CLASS_NAME
is not set,KEYGEN_TYPE
will be read.Therefore, if the default value is set for
KEYGEN_CLASS_NAME
, theKEYGEN_TYPE
configuration is equivalent to completely useless.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then why we still always set up the param
KEYGEN_CLASS_NAME
in this patch for SQL then ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
KEYGEN_CLASS_NAME
is not set, this field will not be displayed in the table properties.KEYGEN_TYPE
is equivalent to an alias ofKEYGEN_CLASS_NAME
, soKEYGEN_TYPE
can be read here to initializeKEYGEN_CLASS_NAME
. And the default value ofKEYGEN_TYPE
isSIMPLE
, soKEYGEN_CLASS_NAME
will be set toSimpleAvroKeyGenerator
by default.According to the above logic, if the user does not set
KEYGEN_CLASS_NAME
,KEYGEN_CLASS_NAME
can be replaced by settingKEYGEN_TYPE
, and after setting,KEYGEN_CLASS_NAME
will also be stored in the table propeties. In this way, the function ofKEYGEN_TYPE
not only conforms to the original logic, but also conforms to the description in the document.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what are we fixing here if
KEYGEN_TYPE
default value is set up and a keygen clazz can be inferred correctly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is no current process, then
KEYGEN_CLASS_NAME
will not be assigned, and there will be no KEYGEN_CLASS_NAME property in table properties.If you set the default value of
KEYGEN_CLASS_NAME
as you said above, then theKEYGEN_TYPE
parameter will be invalid.Therefore, I initialized
KEYGEN_CLASS_NAME
according toKEYGEN_TYPE
, so that not only can the value ofKEYGEN_CLASS_NAME
be saved in table properties, butKEYGEN_TYPE
can also take effect normally according to the original logic.