[HUDI-2057][HUDI-5499] CTAS Generate An External Table When Create Managed Table #6419
+87
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hudi-bot run azure |
dongkelun
force-pushed
the
HUDI-2057
branch
5 times, most recently
from
8b8e052
to
2f1e53d
Compare
yihua
added
spark-sql
priority:critical
yihua
reviewed
Sep 17, 2022
| @@ -174,7 +174,7 @@ trait ProvidesHoodieConfig extends Logging { | |||
|
|
|||
| val enableHive = isUsingHiveCatalog(sparkSession) | |||
|
|
|||
| withSparkConf(sparkSession, catalogProperties) { | |||
| withSparkConf(sparkSession, catalogProperties ++ extraOptions) { | |||
There was a problem hiding this comment.
Could you add a test that should fail before this fix, to guard any breaking changes in the future?
There was a problem hiding this comment.
I can't figure out how to implement the test case.Do you have any ideas?
|
@xushiyan : can you assist the author and help take this home. |
dongkelun
force-pushed
the
HUDI-2057
branch
2 times, most recently
from
496a41c
to
515e9f7
Compare
xushiyan
requested changes
Nov 9, 2022
| | ) | ||
| | location '/tmp/$tableName2' | ||
| | AS | ||
| | select 1 as id, 'a1' as name, 10 as price, 1000 as ts |
There was a problem hiding this comment.
please move this to a proper unit test. Bundle validation is not the right place to execute such tests.
There was a problem hiding this comment.
@xushiyan Hello, the purpose here is to test the type of the sync hive table, but sync hive cannot be realized in unit test
alexeykudinkin
added
priority:blocker
and removed
priority:critical
alexeykudinkin
changed the title
alexeykudinkin
changed the title
alexeykudinkin
added
priority:critical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem has been fixed in this PR before：#3146
Later, the problem was discovered again，But it was fixed by this pr: #3998
The last time this problem reappeared was due to this pr: #5178,The reason is that
extraoptionsis not transferred to spark confChange Logs
CTAS Generate An External Table When Create Managed Table
Impact
CTAS Generate An External Table When Create Managed Table
Risk level (write none, low medium or high below)
none
Contributor's checklist