Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HUDI-4754] Add compliance check in github actions #6575

Merged
merged 33 commits into from Oct 11, 2022
Merged

[HUDI-4754] Add compliance check in github actions #6575

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
353d9b6
pr title and comment validation
jonvex Sep 2, 2022
140189a
should work when edited
jonvex Sep 2, 2022
1600e31
check didn't run, hope this fixes
jonvex Sep 2, 2022
b1bf6ad
going back to how it was before
jonvex Sep 2, 2022
4d02f2c
adding some debugging to env vars
jonvex Sep 2, 2022
9f5bcdb
was setting the title env var to be the body. dumb typo
jonvex Sep 2, 2022
48147d1
getting rid of env vars because they didn't persist
jonvex Sep 2, 2022
a7a693c
this might fix the issue
jonvex Sep 2, 2022
0cb0b8f
capitalization on risk level doesn't matter now
jonvex Sep 2, 2022
c644d73
reducing title constraint so that the minimum number of digits is now 1
jonvex Sep 7, 2022
a2f8065
update test to reflect changes
jonvex Sep 15, 2022
a0d748b
current progress
jonvex Sep 19, 2022
6070ef9
trying to show error message
jonvex Sep 28, 2022
0e2333d
Merge branch 'apache:master' into inspect_pr_compliance
jonvex Sep 28, 2022
fe610b4
fixed typo
jonvex Sep 28, 2022
64ea13e
fixed typo
jonvex Sep 28, 2022
242f21c
addressed all found bugs
jonvex Sep 28, 2022
8977c6c
try to get error message to work
jonvex Sep 28, 2022
76ad961
testing template edit
jonvex Sep 29, 2022
b524fcc
fixed bash error
jonvex Sep 29, 2022
3f2440a
still trying to get template edit check to work
jonvex Sep 29, 2022
3ef2ca8
still having git issue
jonvex Sep 29, 2022
892ca08
disable on pr for faster testing
jonvex Sep 29, 2022
8bf172f
next try
jonvex Sep 29, 2022
5dfc76a
another try
jonvex Sep 29, 2022
17bb02d
another try
jonvex Sep 29, 2022
17d2908
another try
jonvex Sep 29, 2022
bba74fe
reverted change
jonvex Sep 29, 2022
00cd7e6
actually reverted change
jonvex Sep 29, 2022
51979ee
give a better error message
jonvex Sep 29, 2022
7e3c8e9
finished writing the testing
jonvex Oct 3, 2022
5e363b5
got rid of documentation from parsing
jonvex Oct 6, 2022
580379d
updated readme
jonvex Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/pr_compliance.yml
View file
Open in desktop
@@ -0,0 +1,21 @@
name: validate pr
on:
pull_request:
types: [opened, edited, reopened, synchronize]
branches:
- master

jobs:
validate-pr:
runs-on: ubuntu-latest
env:
REQUEST_BODY: ${{ github.event.pull_request.body }}
REQUEST_TITLE: ${{ github.event.pull_request.title }}
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v3
- name: run script
run: python scripts/pr_compliance.py



xushiyan marked this conversation as resolved.
Show resolved Hide resolved