[HUDI-5157] Adding capability to remove all meta fields from source hudi table with Hudi incr source #7132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
added
priority:critical
codope
reviewed
Nov 7, 2022
| final Dataset<Row> src = source.drop(HoodieRecord.HOODIE_META_COLUMNS.stream() | ||
| .filter(x -> !x.equals(HoodieRecord.PARTITION_PATH_METADATA_FIELD)).toArray(String[]::new)); | ||
| String[] colsToDrop = dropAllMetaFields ? HoodieRecord.HOODIE_META_COLUMNS.stream().toArray(String[]::new) : | ||
| HoodieRecord.HOODIE_META_COLUMNS.stream().filter(x -> !x.equals(HoodieRecord.PARTITION_PATH_METADATA_FIELD)).toArray(String[]::new); |
There was a problem hiding this comment.
Do we know what was the reason we strictly dropped partition path in the first place?
There was a problem hiding this comment.
I could not decode that. I don't see a need unless we want to carry over the partitioning from tableA to tableB.
…th hudi incr source
codope
force-pushed
the
chainedHudiTables
branch
from
23edfdd
to
c83686a
Compare
codope
approved these changes
Nov 22, 2022
codope
changed the title
satishkotha
pushed a commit
to satishkotha/incubator-hudi
that referenced
this pull request
Dec 12, 2022
…ith hudi incr source (apache#7132)
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
…ith hudi incr source (apache#7132)
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
…ith hudi incr source (apache#7132)
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
…ith hudi incr source (apache#7132)
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
…ith hudi incr source (apache#7132)
4 tasks
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
…ith hudi incr source (apache#7132)
vinishjail97
pushed a commit
to vinishjail97/hudi
that referenced
this pull request
Dec 15, 2023
…ith hudi incr source (apache#7132) (apache#162) Co-authored-by: Sivabalan Narayanan <n.siva.b@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
HoodieIncrSource was dropping every meta field from source except partition path. If 3 hudi tables are chained (tableA, tableB incrementally reads from tableA, tableC incrementally reads from tableB), the 3rd table when reading from tableB fails w/ duplicate columns. So, adding a config to drop all meta fields. Tested chaining 3 hudi tables in a row and it worked.
Impact
We can chain any number of hudi tables now with Hoodie Incr Source.
Risk level (write none, low medium or high below)
low.
Documentation Update
New config added:
hoodie.deltastreamer.source.hoodieincr.drop.all.meta.fields.from.sourceDefault value is false. When set to true, chaining of any number of tables work.
Contributor's checklist