Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-5238] Fixing HoodieMergeHandle shutdown sequence #7245

Merged
merged 7 commits into from May 19, 2023

Conversation

alexeykudinkin
Copy link
Contributor

@alexeykudinkin alexeykudinkin commented Nov 19, 2022

Change Logs

This PR addresses the #7234 related to HoodieMergeHandle shutdown sequence:
in introduced at #4264 we changed the ordering in which we shut down the handle relative to the executor:

Before it was

  1. Handle
  2. Executor

After

  1. Executor
  2. Handle

The reason it was switched was to handle the case when during exception thrown executor might still be writing out records, and closing of the handle (before the executor) was leaving some of the produced Parquet files corrupted.

This PR, addresses this issue by making sure that in the successful path we close the Handle immediately as soon as writing has finished (before we shutdown the executor), which would make sure this will not result in any PipeBroken exceptions in GCS

Impact

No impact

Risk level (write none, low medium or high below)

Low

Documentation Update

N/A

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@codope codope added priority:critical production down; pipelines stalled; Need help asap. writer-core Issues relating to core transactions/write actions labels Nov 28, 2022
@nsivabalan nsivabalan added priority:blocker and removed priority:critical production down; pipelines stalled; Need help asap. labels Dec 6, 2022
@nsivabalan nsivabalan self-assigned this Dec 6, 2022
@nsivabalan nsivabalan added the release-0.12.2 Patches targetted for 0.12.2 label Dec 6, 2022
@alexeykudinkin alexeykudinkin removed the release-0.12.2 Patches targetted for 0.12.2 label Dec 6, 2022
@codope codope added the release-0.12.2 Patches targetted for 0.12.2 label Dec 7, 2022
@alexeykudinkin alexeykudinkin changed the title [HUDI-5238][Stacked on 7238] Fixing HoodieMergeHandle shutdown sequence [HUDI-5238] Fixing HoodieMergeHandle shutdown sequence Dec 8, 2022
@alexeykudinkin alexeykudinkin removed the release-0.12.2 Patches targetted for 0.12.2 label Dec 8, 2022
@alexeykudinkin alexeykudinkin added priority:critical production down; pipelines stalled; Need help asap. and removed priority:blocker labels Jan 25, 2023
@alexeykudinkin alexeykudinkin force-pushed the ak/exeq-trdwn-fix branch 2 times, most recently from 85eaa8d to 9fd17ce Compare February 17, 2023 18:42
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@xushiyan xushiyan merged commit 4c980f3 into apache:master May 19, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:critical production down; pipelines stalled; Need help asap. release-0.14.0 writer-core Issues relating to core transactions/write actions
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants