New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-5238] Fixing HoodieMergeHandle
shutdown sequence
#7245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codope
added
priority:critical
production down; pipelines stalled; Need help asap.
writer-core
Issues relating to core transactions/write actions
labels
Nov 28, 2022
4 tasks
nsivabalan
added
priority:blocker
and removed
priority:critical
production down; pipelines stalled; Need help asap.
labels
Dec 6, 2022
alexeykudinkin
force-pushed
the
ak/exeq-trdwn-fix
branch
from
December 8, 2022 04:03
6146275
to
2c234af
Compare
alexeykudinkin
changed the title
[HUDI-5238][Stacked on 7238] Fixing
[HUDI-5238] Fixing Dec 8, 2022
HoodieMergeHandle
shutdown sequenceHoodieMergeHandle
shutdown sequence
alexeykudinkin
added
priority:critical
production down; pipelines stalled; Need help asap.
and removed
priority:blocker
labels
Jan 25, 2023
alexeykudinkin
force-pushed
the
ak/exeq-trdwn-fix
branch
2 times, most recently
from
February 17, 2023 18:42
85eaa8d
to
9fd17ce
Compare
nsivabalan
force-pushed
the
ak/exeq-trdwn-fix
branch
from
March 17, 2023 23:32
9fd17ce
to
811eac5
Compare
…handles w/in the executor's consumers, as soon as writing is completed
xushiyan
force-pushed
the
ak/exeq-trdwn-fix
branch
from
May 19, 2023 08:28
49aea36
to
f5753cd
Compare
xushiyan
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority:critical
production down; pipelines stalled; Need help asap.
release-0.14.0
writer-core
Issues relating to core transactions/write actions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
This PR addresses the #7234 related to
HoodieMergeHandle
shutdown sequence:in introduced at #4264 we changed the ordering in which we shut down the handle relative to the executor:
Before it was
After
The reason it was switched was to handle the case when during exception thrown executor might still be writing out records, and closing of the handle (before the executor) was leaving some of the produced Parquet files corrupted.
This PR, addresses this issue by making sure that in the successful path we close the Handle immediately as soon as writing has finished (before we shutdown the executor), which would make sure this will not result in any
PipeBroken
exceptions in GCSImpact
No impact
Risk level (write none, low medium or high below)
Low
Documentation Update
N/A
Contributor's checklist