[HUDI-5357] Optimize deployment of release artifacts #7419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Still need to verify if different avro versions should be set for hive, presto, trino bundles |
xushiyan
added
dependencies
danny0405
reviewed
Dec 15, 2022
| # flink bundles (overwriting previous uploads) | ||
| "-Dscala-2.12 -Dflink1.13 -Davro.version=1.10.0 -pl packaging/hudi-flink-bundle" | ||
| "-Dscala-2.12 -Dflink1.14 -Davro.version=1.10.0 -pl packaging/hudi-flink-bundle" | ||
| "-Dscala-2.12 -Dflink1.15 -Davro.version=1.10.0 -pl packaging/hudi-flink-bundle" |
There was a problem hiding this comment.
The hard code avro version is hard to maintain.
There was a problem hiding this comment.
unfortunately this is a short term workaround. Putting this in flink profiles under pom.xml will conflict with spark profiles, which interfere with current build commands used in azure CI, which takes much more efforts to resolve. Due to time constraint, overwriting the version from maven cmd is the shortest solution.
xushiyan
changed the title
xushiyan
force-pushed
the
HUDI-5357-release-deployment
branch
from
d3b268b
to
5a1be2a
Compare
xushiyan
changed the title
xushiyan
changed the title
nsivabalan
reviewed
Dec 16, 2022
nsivabalan
approved these changes
Dec 16, 2022
nsivabalan
pushed a commit
that referenced
this pull request
Dec 17, 2022
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Optimize upload release artifacts.
flink bundle use 1.10.0 avro version, but hudi common modes were generated during build process controlled by
avro.versionproperty, which is not overwritten in flink profiles. This would resulted in generated models being incompatible with included avro lib in flink-bundle.This change makes sure flink bundle is built and released with the desired avro version and hudi-common models
Fix #7259
Fix #7047
JIRA
Impact
Release artifacts
Risk level
High.
Needs proper validation of the artifacts.
Documentation Update
NA
Contributor's checklist