[HUDI-5336] Fixing log file pattern match to ignore extraneous files #7612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihua
reviewed
Jan 12, 2023
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java
Outdated
Show resolved
Hide resolved
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java
Outdated
Show resolved
Hide resolved
|
|
yihua
reviewed
Jan 19, 2023
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java
Outdated
Show resolved
Hide resolved
| @@ -134,7 +134,7 @@ public void testFailedToGetAppendStreamFromHDFSNameNode() | |||
| // Opening a new Writer right now will throw IOException. The code should handle this, rollover the logfile and | |||
| // return a new writer with a bumped up logVersion | |||
| writer = HoodieLogFormat.newWriterBuilder().onParentPath(testPath) | |||
| .withFileExtension(HoodieArchivedLogFile.ARCHIVE_EXTENSION).withFileId("commits.archive") | |||
| .withFileExtension(HoodieArchivedLogFile.ARCHIVE_EXTENSION).withFileId("commits") | |||
There was a problem hiding this comment.
does this mean the original tests do not properly construct the archived log file name?
hudi-common/src/test/java/org/apache/hudi/common/table/view/TestHoodieTableFileSystemView.java
Show resolved
Hide resolved
|
Failed due to flaky flink IT test |
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Jan 31, 2023
…pache#7612) Co-authored-by: Y Ethan Guo <ethan.guoyihua@gmail.com>
nsivabalan
added a commit
to nsivabalan/hudi
that referenced
this pull request
Mar 22, 2023
…pache#7612) Co-authored-by: Y Ethan Guo <ethan.guoyihua@gmail.com>
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
…pache#7612) Co-authored-by: Y Ethan Guo <ethan.guoyihua@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
GCS might create some marker files for log files created by hudi. While constructing the file groups w/ log files, we should ignore such files. Format of those marker file is "GCS_SYNCABLE_TEMPFILE" + [LOG_FILE_NAME]. Eg: "GCS_SYNCABLE_TEMPFILE.files-0000_20230104082331173001.log.10_0-52-553.1.8170c3dc-f1f0-474f-aabf-b53a474aa18d".
We did make an attempt to fix before, but looks like the file pattern is different. So, have made the pattern match more strict.
This patch fixes the Log file pattern match to ensure we ignore such extraneous files.
Impact
Queries and compaction may not fail occationally.
Risk level (write none, low medium or high below)
low.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
N/A
Contributor's checklist