[HUDI-5629] Clean CDC log files for enable/disable scenario #7767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
reviewed
Jan 28, 2023
| // and normal log files for mor tables. | ||
| cleanPaths.addAll( | ||
| nextSlice.getLogFiles().map(lf -> new CleanFileInfo(lf.getPath().toString(), false)) | ||
| .collect(Collectors.toList())); | ||
| return cleanPaths; |
There was a problem hiding this comment.
Should pre-condition hoodieTable.getMetaClient().getTableType() == HoodieTableType.MERGE_ON_READ be kept for efficiency?
xushiyan
approved these changes
Jan 28, 2023
xushiyan
changed the title
|
The failed UTs is not related to this pr, but fixed in #7768. Now merge this. |
4 tasks
yihua
pushed a commit
that referenced
this pull request
Jan 30, 2023
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Jan 31, 2023
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
According the current clean logic about cdc, clean cdc log files only when the cdc config is enabled. But if a table enables cdc first, then disables it, will probably leave some cdc log files which can't be cleaned.
So clean log files if exists directly.
Impact
NONE
Risk level (write none, low medium or high below)
NONE
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist