Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-6032] Fix read meta field '_hoodie_commit_time' multiple times #8398

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

LinMingQiang
Copy link
Contributor

@LinMingQiang LinMingQiang commented Apr 6, 2023

Change Logs

Fix Read metafield '_hoodie_commit_time' multiple times

Impact

none
Describe any public API or user-facing feature change or any performance impact.

Risk level (write none, low medium or high below)

none

If medium or high, explain what verification was done to mitigate the risks.

Documentation Update

none

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@LinMingQiang
Copy link
Contributor Author

@hudi-bot run azure

@danny0405
Copy link
Contributor

6032.patch.zip
Thanks for the contribution, I have reviewed and applied a patch.

@danny0405 danny0405 self-assigned this Apr 7, 2023
@danny0405 danny0405 changed the title [HUDI-6032] Fix Read metafield '_hoodie_commit_time' multiple times [HUDI-6032] Fix read meta field '_hoodie_commit_time' multiple times Apr 7, 2023
@LinMingQiang
Copy link
Contributor Author

Thank you for the review, I have already applied the patch.

Copy link
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks for the contribution, @LinMingQiang ~

@LinMingQiang
Copy link
Contributor Author

LinMingQiang commented Apr 7, 2023

I found that some case were not covered, so I extended the test cases. And fixed a missing bug that in without meta fields query case.

@danny0405
Copy link
Contributor

@LinMingQiang
Copy link
Contributor Author

@hudi-bot
Copy link

hudi-bot commented Apr 7, 2023

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@danny0405 danny0405 merged commit 9729415 into apache:master Apr 7, 2023
15 checks passed
KnightChess pushed a commit to KnightChess/hudi that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants